This repository was archived by the owner on Jul 26, 2023. It is now read-only.
SetWindowLongPtr on 32-bit #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation for `SetWindowLongPtr`,
> When compiling for 32-bit Windows, `SetWindowLongPtr` is defined as a call to the `SetWindowLong` function.
What this really means is that calls to `PInvoke.User32.SetWindowLongPtr` on 32-bit processes will (and do) result in an `EntryPointNotFoundException`
This fix exposes `SetWindowLongPtr` through `User32.Helpers.cs` by conditionally calling `SetWindowLongPtr` on 64-bit vs. `SetWindowLong` on 32-bit.
Upating xml-doc comments Add a test case
ghost
mentioned this pull request
AArnott
suggested changes
May 11, 2018
src/User32/User32.cs
Outdated
| /// When compiling for 32-bit Windows, SetWindowLongPtr is defined as a call to the SetWindowLong function. This | ||
| /// function is exposed using a helper that conditionally calls SetWindowLong in 32-bit processes. | ||
| /// </remarks> | ||
| [DllImport(nameof(User32), SetLastError = true, EntryPoint = nameof(SetWindowLongPtr))] |
There was a problem hiding this comment.
I don't think we should use nameof(SetWindowLongPtr) for the EntryPoint here. That's the name of the helper method, and if we ever renamed that method, it would not be correct to change the string here.
There was a problem hiding this comment.
Done. Also, I added another definition as part of the latest commit (AdjustWindowRectEx). Just filling in the gaps as I find 'em.
| /// through the number of bytes of extra window memory, minus the size of a LONG_PTR. To set any other value, | ||
| /// specify one of the following values. | ||
| /// | ||
| /// <list type="table"> |
There was a problem hiding this comment.
nice translation to xml! 😄
There was a problem hiding this comment.
Thanks, didn't know until now that "list" could mean "table" :)
…of(SetWindowLongPtr) to "SetWindowLongPtr" - Adding definition for AdjustWindowRectEx
AArnott
approved these changes
May 11, 2018
AArnott
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation for
SetWindowLongPtr,What this really means is that calls to
PInvoke.User32.SetWindowLongPtron 32-bit processes will (and do) result in anEntryPointNotFoundExceptionThis fix exposes
SetWindowLongPtrthroughUser32.Helpers.csby conditionally callingSetWindowLongPtron 64-bit vs.SetWindowLongon 32-bit.Also, adding a test.
Fixes #385