Skip to content
This repository was archived by the owner on Jul 26, 2023. It is now read-only.

Put WNDCLASS fields in the correct order #371

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Feb 13, 2018

https://msdn.microsoft.com/library/windows/desktop/ms633577

Caused no small amount of head scratching until I saw it!

@vbfox
Copy link
Collaborator

vbfox commented Feb 13, 2018

Nice I checked the PR that introduced it and 4 structs had member that were alphabetically ordered:

  • WNDCLASS (Fixed since then)
  • WNDCLASSEX (Fixed since then except for theses 2 fields)
  • MINMAXINFO (Still bad)
  • WINDOWINFO (Still bad)

I'll PR the 2 other

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for the time you lost in head scratching.

@AArnott AArnott merged commit cb7e5fb into dotnet:master Feb 14, 2018
@jnm2
Copy link
Contributor Author

jnm2 commented Feb 14, 2018

Thanks! And sorry for the time you lost in head scratching.

I appreciate that, but no need. If it wasn't this it would have been something else, and I'm okay with that or I wouldn't make a good programmer! 😊

@AArnott
Copy link
Collaborator

AArnott commented Feb 14, 2018

This is published to nuget.org now, btw

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants