-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ML.NET rolling and fixed version CI legs #988
Changes from all commits
dc5c8a0
da0c319
8cd2420
270923a
1c3984c
f5bddfc
11ebf05
0a853d9
cba0daf
0943115
369eca4
46ecb70
3b86165
b57d9dc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,13 @@ def add_arguments(parser: ArgumentParser) -> ArgumentParser: | |
type=str, | ||
help='Product repository.' | ||
) | ||
parser.add_argument( | ||
'--lib-version', | ||
dest='lib_version', | ||
required=False, | ||
type=str, | ||
help='Version of the tested library. Supported only by some projects' | ||
) | ||
|
||
def __is_valid_datetime(dt: str) -> str: | ||
try: | ||
|
@@ -213,6 +220,10 @@ def __main(args: list) -> int: | |
target_framework_monikers | ||
) | ||
|
||
# set the product version using Env Vars handled by the MSBuild project file | ||
if args.lib_version: | ||
os.environ['PERFLAB_LIBRARY_VERSION'] = args.lib_version | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we instead pass it in through There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. BDN also performs |
||
|
||
# dotnet --info | ||
dotnet.info(verbose=verbose) | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how the new uploader works so I've just extended the
RunKind
string withfixed|rolling
This parameter is optional and null by default, so the "id" should change only for ML.NET runsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like the right way to go about this.