Update Blazor warning condition to net12.0 threshold#5085
Merged
LoopedBard3 merged 2 commits intomainfrom Jan 20, 2026
Merged
Conversation
…heck from 9.0 to 11.0 Co-authored-by: LoopedBard3 <15679138+LoopedBard3@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update warning condition for package version checks
Update Blazor warning condition to net12.0 threshold
Jan 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the warning condition in the Blazor build targets to prevent false warnings for .NET 10.0 and 11.0, which already have proper package version configurations defined.
Changes:
- Updated warning threshold from net10.0/9.0 to net12.0/11.0 in Blazor.Directory.Build.targets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The warning in
Blazor.Directory.Build.targetswas triggering incorrectly for net10.0 and net11.0 builds despite both having proper package version definitions inBlazor.PackageVersions.props.Changes
Updated the warning condition in
src/scenarios/build-common/Blazor.Directory.Build.targets(line 8):net10.0→net12.0VersionGreaterThan('9.0')→VersionGreaterThan('11.0')The warning now only triggers for net12.0+ TFMs that lack package version configurations, aligning with the existing definitions in
Blazor.PackageVersions.propswhich include net10.0 and net11.0.Original prompt
This pull request was created from Copilot chat.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.