-
Notifications
You must be signed in to change notification settings - Fork 280
F# micro benchmarks #4051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F# micro benchmarks #4051
Conversation
/azp run |
Commenter does not have sufficient privileges for PR 4051 in repo dotnet/performance |
Generally looks good for a starting point to me. Going to check with the team tomorrow to determine if this is the right place for it to live or if a different folder would make more sense. |
Hello, got some feedback on the location. We think that the work should be put in its own folder under |
Hey, thanks for the feedback - no problem, I will reorganize the files as suggested, stay tuned :) |
Hey @LoopedBard3, I updated the benchmarks as asked. The CI is failing now but for something else - I cannot understand if it's related or not, but doesn't seem to be flaky - I reran it a few times. |
These failures are unrelated, so you are all good 👍. Are you ready for this to be merged in? |
Yeah, all good from my side :) |
This is the first set of F# micro benchmarks.
I am not sure how to best locate it, happy to rearrange things if needed. F# benchmarks cannot be in the
MicroBenchmarks.csproj
solution because .cs and .fs files don't mix, but otherwise the benchmarks are quite similar to C# micro benchmarks.Here are the local results for reference: