Revert https://github.com/dotnet/performance/commit/860d6a17d0c17592e2f4d803038d99969f3d8778 #3222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoopedBard3
requested review from
sblom,
cincuranet,
DrewScoggins and
caaavik-msft
|
How did we miss that this didn't fix it before? |
|
The runs I tested for this before was only on window and ubuntu missing the mac version. The same removal also went into the runtime repo without causing any issues, so there is something (likely a version somewhere) that still has the breaking change on OSX. |
|
We also don't run OSX steps on public-ci because we only have on-prem testing hardware. |
|
OK, that makes sense. |
DrewScoggins
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #3179 (860d6a1) as the tool build is still broken on the iOS builds.
Test of proper building of tools (each scenario made it past building tools): https://dev.azure.com/dnceng/internal/_build/results?buildId=2235822&view=results