Skip to content

Use the Maestro versions for MicroBenchmarks.csproj #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Use the Maestro versions for MicroBenchmarks.csproj #3175

merged 1 commit into from
Jul 28, 2023

Conversation

cincuranet
Copy link
Contributor

@cincuranet cincuranet commented Jul 27, 2023

Depends on #3174 and #3173.
Fixes #3164.

@cincuranet cincuranet self-assigned this Jul 27, 2023
@cincuranet cincuranet linked an issue Jul 27, 2023 that may be closed by this pull request
LoopedBard3
LoopedBard3 previously approved these changes Jul 27, 2023
@SamMonoRT
Copy link
Member

cc @radical @kotlarmilos

@lewing
Copy link
Member

lewing commented Jul 27, 2023

running darc update-dependencies --channel ".NET 8" or darc update-dependencies --id 186291 on this pr will get you real version numbers for the deps. It will also update the illink versions, is that going to be a problem?

@cincuranet
Copy link
Contributor Author

@lewing I already rebased on top of #3176, so we're good. Regarding ILLink, let's see.

@DrewScoggins
Copy link
Member

It shouldn't be an issue for the real version numbers for our extension assemblies. The Illink dependency update is a bit more interesting. @sbomer

@radical
Copy link
Member

radical commented Jul 27, 2023

@cincuranet are you already running a build on dotnet-runtime-perf for this?

@radical
Copy link
Member

radical commented Jul 27, 2023

/datadisks/disk1/work/B4900A21/w/9E8D08B7/e/src/benchmarks/real-world/ILLink/ILLinkBenchmarks.csproj : error NU1603: Warning As Error: ILLinkBenchmarks depends on Microsoft.NET.ILLink (>= 8.0.0-rc.1.23377.1) but Microsoft.NET.ILLink 8.0.0-rc.1.23377.1 was not found. An approximate best match of Microsoft.NET.ILLink 8.0.100-1.22608.1 was resolved.

radical added a commit to radical/runtime that referenced this pull request Jul 27, 2023
@radical
Copy link
Member

radical commented Jul 27, 2023

I have started https://dev.azure.com/dnceng/internal/_build/results?buildId=2230773 for this branch. But this will run only wasm jobs, because for wasm we can run off a fork.

diff --git a/eng/pipelines/coreclr/perf.yml b/eng/pipelines/coreclr/perf.yml
index ae734cbfdaa..b4f3f673964 100644
--- a/eng/pipelines/coreclr/perf.yml
+++ b/eng/pipelines/coreclr/perf.yml
@@ -49,5 +49,8 @@ extends:
             runProfile: 'non-v8'
           ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'Schedule')) }}:
             runProfile: 'v8'
+          perfForkToUse:
+            url: https://github.com/cincuranet/performance
+            branch: maestro-version

-      - template: /eng/pipelines/coreclr/perf-non-wasm-jobs.yml
+      #- template: /eng/pipelines/coreclr/perf-non-wasm-jobs.yml

@radical
Copy link
Member

radical commented Jul 28, 2023

I have started dev.azure.com/dnceng/internal/_build/results?buildId=2230773 for this branch. But this will run only wasm jobs, because for wasm we can run off a fork.

All the wasm jobs just timed out waiting for helix agents, after 5+ hours. @LoopedBard3 have the machines taken out for testing been added back? I have been hitting this issue for quite some time now.

@cincuranet
Copy link
Contributor Author

@radical We have currently migration from Ubuntu 18.04 to 22.04 happening and that queue is temporarily operating with limited capacity.

@radical
Copy link
Member

radical commented Jul 28, 2023

@radical We have currently migration from Ubuntu 18.04 to 22.04 happening and that queue is temporarily operating with limited capacity.

Is the only way to test this is to merge it then?

@SamMonoRT
Copy link
Member

@sblom @cincuranet - If merging is the only way we can test this, I would suggest merge this asap. Runs seem completely broken at this time and we need to give it a shot.

@cincuranet
Copy link
Contributor Author

@radical It will end up in the same queue.

@cincuranet
Copy link
Contributor Author

If somebody gives me approval, I'll merge ASAP.

@radical
Copy link
Member

radical commented Jul 28, 2023

@radical It will end up in the same queue.

But dotnet-runtime-perf does seem to get some preference? I have tried this a few times recently, where I can't get any agents when doing a manual pipeline run, but it works fine with dotnet-runtime-perf. Maybe this was a coincidence, I don't know.

@cincuranet cincuranet merged commit 9a4ce8a into dotnet:main Jul 28, 2023
@cincuranet cincuranet deleted the maestro-version branch July 28, 2023 16:56
@cincuranet
Copy link
Contributor Author

I'm not aware of any preference, but maybe there's some logic there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[perf] Dotnet restore unable to find 8.0.0-rc.* packages
6 participants