Skip to content

Bumped BDN version #2639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Bumped BDN version #2639

merged 4 commits into from
Oct 11, 2022

Conversation

naricc
Copy link

@naricc naricc commented Oct 7, 2022

Update BDN version to fix issue with llvm aot. I believe the new version has to be uploaded somewhere before we merge this?

Fixes: #2625

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the new version has to be uploaded somewhere before we merge this?

Yes, someone from the .NET Performance Team needs to upload copy of BDN package to our internal preview feed. cc @LoopedBard3 @DrewScoggins

This time the update will also require uploading a new BDN dependency: https://www.nuget.org/packages/Gee.External.Capstone/2.2.0 which is used by the new Arm64 disassembler.

Moreover there were some minor breaking changes that require two simple line changes like: adamsitnik@03409e3

And #2314 needs to be reverted as this feature has been now added to BDN. (dotnet/BenchmarkDotNet#2132)

@LoopedBard3
Copy link
Member

The Capstone package and BDN version have been uploaded.

@naricc
Copy link
Author

naricc commented Oct 11, 2022

@adamsitnik Does #2314 need to be reverted as part of thing change? It seems like dotnet/performance will just consume the arguments and BDN will not see them. I'd assume do the revert separately unless it breaks things?

@naricc
Copy link
Author

naricc commented Oct 11, 2022

Looks like I answered my own question there; reverted.

Copy link
Member

@LoopedBard3 LoopedBard3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming clean ci run and comment is answered.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your work on this @naricc !

@LoopedBard3 thank you for your help!

@LoopedBard3
Copy link
Member

The sdk_scenario error is unrelated to this change and I don't think the centOS ones are either, though they may be. Regardless, I have an issue tracking the centos errors here: #2646.

@naricc naricc merged commit 4a35773 into dotnet:main Oct 11, 2022
@lewing
Copy link
Member

lewing commented Oct 14, 2022

This appears to be breaking the wasm pipeline due to the changes in dotnet/BenchmarkDotNet#2117

@lewing
Copy link
Member

lewing commented Oct 14, 2022

@radical can you link to one of the failures?

@radical
Copy link
Member

radical commented Oct 14, 2022

The failure log:

Precompiling failed for /home/helixbot/work/BDBD0A7F/w/9C5C0885/e/performance/artifacts/bin/for-running/MicroBenchmarks/50a8be8a-1310-4eec-a7ed-9ea351446f5f/bin/net7.0/browser-wasm/publish/BenchmarkDotNet.dll with exit code 134. 
Failed to load methodspec 0x2b000262 due to Could not load file or assembly 'Mono.Posix.NETStandard, Version=1.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.. 
Run with MONO_LOG_LEVEL=debug for more information. 
Unable to compile method 'bool BenchmarkDotNet.Diagnosers.PerfCollectProfiler:TryInstallPerfCollect (BenchmarkDotNet.Validators.ValidationParameters)' due to: 'Could not load file or assembly 'Mono.Posix.NETStandard, Version=1.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.'. 
Unable to compile method 'void BenchmarkDotNet.Diagnosers.PerfCollectProfiler:StopCollection (BenchmarkDotNet.Diagnosers.DiagnoserActionParameters)' due to: 'Could not load file or assembly 'Mono.Posix.NETStandard, Version=1.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.'. 
Unable to compile method 'bool BenchmarkDotNet.Diagnosers.PerfCollectProfiler/<Validate>d__18:MoveNext ()' due to: 'Could not load file or assembly 'Mono.Posix.NETStandard, Version=1.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies.'. 
corrupted size vs. prev_size 

Precompiling failed for /home/helixbot/work/BDBD0A7F/w/9C5C0885/e/performance/artifacts/bin/for-running/MicroBenchmarks/50a8be8a-1310-4eec-a7ed-9ea351446f5f/bin/net7.0/browser-wasm/publish/System.Linq.dll with exit code 139. 
Precompiling failed for /home/helixbot/work/BDBD0A7F/w/9C5C0885/e/performance/artifacts/bin/for-running/MicroBenchmarks/50a8be8a-1310-4eec-a7ed-9ea351446f5f/bin/net7.0/browser-wasm/publish/Microsoft.Diagnostics.Tracing.TraceEvent.dll with exit code 139. 
Precompiling failed for /home/helixbot/work/BDBD0A7F/w/9C5C0885/e/performance/artifacts/bin/for-running/MicroBenchmarks/50a8be8a-1310-4eec-a7ed-9ea351446f5f/bin/net7.0/browser-wasm/publish/MicroBenchmarks.dll with exit code 139. 
Precompiling failed for /home/helixbot/work/BDBD0A7F/w/9C5C0885/e/performance/artifacts/bin/for-running/MicroBenchmarks/50a8be8a-1310-4eec-a7ed-9ea351446f5f/bin/net7.0/browser-wasm/publish/System.Private.Xml.dll with exit code 139. 
Precompiling failed for /home/helixbot/work/BDBD0A7F/w/9C5C0885/e/performance/artifacts/bin/for-running/MicroBenchmarks/50a8be8a-1310-4eec-a7ed-9ea351446f5f/bin/net7.0/browser-wasm/publish/System.Private.CoreLib.dll with exit code 139. 

@lewing
Copy link
Member

lewing commented Oct 14, 2022

cc @SamMonoRT @jeffhandley

@adamsitnik
Copy link
Member

I've sent a "fix": dotnet/BenchmarkDotNet#2154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mono AOT Arm64 failing
5 participants