-
Notifications
You must be signed in to change notification settings - Fork 282
Bumped BDN version #2639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped BDN version #2639
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the new version has to be uploaded somewhere before we merge this?
Yes, someone from the .NET Performance Team needs to upload copy of BDN package to our internal preview feed. cc @LoopedBard3 @DrewScoggins
This time the update will also require uploading a new BDN dependency: https://www.nuget.org/packages/Gee.External.Capstone/2.2.0 which is used by the new Arm64 disassembler.
Moreover there were some minor breaking changes that require two simple line changes like: adamsitnik@03409e3
And #2314 needs to be reverted as this feature has been now added to BDN. (dotnet/BenchmarkDotNet#2132)
The Capstone package and BDN version have been uploaded. |
@adamsitnik Does #2314 need to be reverted as part of thing change? It seems like dotnet/performance will just consume the arguments and BDN will not see them. I'd assume do the revert separately unless it breaks things? |
This reverts commit 92aba53.
Looks like I answered my own question there; reverted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming clean ci run and comment is answered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your work on this @naricc !
@LoopedBard3 thank you for your help!
The sdk_scenario error is unrelated to this change and I don't think the centOS ones are either, though they may be. Regardless, I have an issue tracking the centos errors here: #2646. |
This appears to be breaking the wasm pipeline due to the changes in dotnet/BenchmarkDotNet#2117 |
@radical can you link to one of the failures? |
The failure log:
|
I've sent a "fix": dotnet/BenchmarkDotNet#2154 |
Update BDN version to fix issue with llvm aot. I believe the new version has to be uploaded somewhere before we merge this?
Fixes: #2625