Skip to content

Add TAR async benchmarks #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Add TAR async benchmarks #2533

merged 3 commits into from
Aug 5, 2022

Conversation

carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jul 19, 2022

@adamsitnik @dakersnar I'm copying the existing sync benchmarks and making them async.

Important!

Do not merge yet! This change depends on moving the performance microbenchmarks project to consume preview7. These async APIs did not exist in preview6.

Copy link
Contributor

@dakersnar dakersnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable addition, LGTM. @adamsitnik could you take a look too?

@danmoseley
Copy link
Member

AOT tests failing @LoopedBard3

[2022/07/21 03:29:55][INFO] /home/helixbot/work/B704099E/w/AB960977/e/tools/dotnet/x64/sdk/7.0.100-rc.1.22370.11/Sdks/Microsoft.NET.ILLink.Tasks/build/Microsoft.NET.ILLink.targets(230,5): warning : Property 'TrimmerDefaultAction' is deprecated in .NET 7 and will be ignored. Use TrimMode instead. [/home/helixbot/work/B704099E/w/AB960977/e/artifacts/bin/MicroBenchmarks/Release/net7.0/34e94fe1-6ded-4356-abfa-dd177f64422b/BenchmarkDotNet.Autogenerated.csproj]
[2022/07/21 03:29:55][INFO]   Generating native code
[2022/07/21 03:29:55][INFO] EXEC : error : invalid option --instructionset [/home/helixbot/work/B704099E/w/AB960977/e/artifacts/bin/MicroBenchmarks/Release/net7.0/34e94fe1-6ded-4356-abfa-dd177f64422b/BenchmarkDotNet.Autogenerated.csproj]
[2022/07/21 03:29:55][INFO] /home/helixbot/work/B704099E/w/AB960977/e/artifacts/packages/microsoft.dotnet.ilcompiler/7.0.0-rc.1.22370.5/build/Microsoft.NETCore.Native.targets(271,5): error MSB3073: The command ""/home/helixbot/work/B704099E/w/AB960977/e/artifacts/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/7.0.0-rc.1.22370.5/tools/ilc" @"/home/helixbot/work/B704099E/w/AB960977/e/artifacts/obj/BenchmarkDotNet.Autogenerated/Release/net7.0/linux-x64/native/34e94fe1-6ded-4356-abfa-dd177f64422b.ilc.rsp"" exited with code 1. [/home/helixbot/work/B704099E/w/AB960977/e/artifacts/bin/MicroBenchmarks/Release/net7.0/34e94fe1-6ded-4356-abfa-dd177f64422b/BenchmarkDotNet.Autogenerated.csproj]
[2022/07/21 03:29:55][INFO] 
[2022/07/21 03:29:55][INFO] // BenchmarkDotNet has failed to build the auto-generated boilerplate code.

@carlossanlop
Copy link
Contributor Author

@danmoseley interesting to see that nothing else failed. So does that mean microbenchmarks is already consuming preview6?

@LoopedBard3 I see you merged this PR, which contains the only mention of preview6: #2399

I see globals.json mentions preview5 as dependency for "tools" (not sure what that means):

"dotnet": "7.0.100-preview.5.22307.18"

Can you help me confirm what's the currently consumed .NET version in microbenchmarks?

@LoopedBard3
Copy link
Member

It looks like the one that is being used to run the microbenchmarks is version 7.0.100-rc.1.22371.5, based on the logs from the ci_setup step. There is a chance that the fix for #2496 will also help here since we are not seeing the error in those runs.

@carlossanlop
Copy link
Contributor Author

/azp run performance-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danmoseley
Copy link
Member

@LoopedBard3 seems still broken.

@LoopedBard3
Copy link
Member

The centos issues seem to have been solved 4 days ago: #2532. Lets try a new run to see if it solved the issues here or if any new ones show up.

@LoopedBard3
Copy link
Member

/azp run performance-ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @carlossanlop !

@adamsitnik
Copy link
Member

@DrewScoggins these benchmarks require Preview 7 SDK. The build is green for dotnet/performance because this repo uses the latest SDK, but how about dotnet/runtime that also builds these benchmarks? Can we merge this PR without breaking dotnet/runtime perf runs?

@LoopedBard3
Copy link
Member

Ran a test run using a version of this with BDN updated: https://dev.azure.com/dnceng/internal/_build/results?buildId=1921391&view=results. It looks like we should be good since we run are running latest runtime bits during testing.

@adamsitnik adamsitnik merged commit bcb7ce1 into dotnet:main Aug 5, 2022
@adamsitnik
Copy link
Member

@LoopedBard3 thanks!

@carlossanlop carlossanlop deleted the TarAsync branch August 8, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants