Skip to content

Wrap certification initialization with try-catch #2469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Jun 6, 2022

From last few weeks we are seeing issue in superpmi where the MicroBenchmarks.dll execution fails on startup. This is before it starts executing any test. The code does static fields initialization and few fields rely on certificates to be present on the machine. For some reason, this is not the case on the test machines where superpmi collect pipeline is run and because of this failure, we are unable to do any collection for benchmarks.

This PR wraps the certificate code with try-catch so even if it fails, it will just fail the respective benchmarks test instead of the entire MicroBenchmark.dll.

Related: #2454

@kunalspathak
Copy link
Member Author

cc: @BruceForstall
@DrewScoggins - can we get this in so we can unblock our superpmi collections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants