Skip to content

Add Perf_Guid::EqualsNotSame benchmark #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 30, 2022
Merged

Add Perf_Guid::EqualsNotSame benchmark #2324

merged 3 commits into from
Mar 30, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Mar 20, 2022 •
edited
Loading

I noticed that we don't have a benchmark for a fairly common case - when we compare two unequal guids

For reference dotnet/runtime#66889

adamsitnik
adamsitnik approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @EgorBo !

@adamsitnik adamsitnik merged commit fa92fed into dotnet:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorBo @adamsitnik