Skip to content

[master] Update dependencies from dotnet/installer #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jun 20, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/installer

  • Subscription: 6f4016b8-3ae8-40ec-eda7-08d7d0ee12d3
  • Build: 20200619.6
  • Date Produced: 6/20/2020 12:48 AM
  • Commit: 3c6656f83b01ece6af7e11eb75ec0145554b139d
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.Dotnet.Sdk.Internal: from 5.0.100-preview.7.20318.12 to 5.0.100-preview.7.20319.6

…200619.6

Microsoft.Dotnet.Sdk.Internal
 From Version 5.0.100-preview.7.20318.12 -> To Version 5.0.100-preview.7.20319.6
@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 20, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: performance-ci, performance-ci (windows RS5 x64 roslyn master), performance-ci (windows RS5 x64 micro master)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@adamsitnik
Copy link
Member

The CI fails with a really strange error:

 --------------------------------------------------
 Building .NET micro benchmarks for 'netcoreapp5.0'
 --------------------------------------------------
 $ pushd "C:\h\w\B47C094C\p\src\benchmarks\micro"
 $ dotnet build C:\h\w\B47C094C\p\src\benchmarks\micro\MicroBenchmarks.csproj --configuration Release --framework netcoreapp5.0 --no-restore /p:NuGetPackageRoot=C:\h\w\B47C094C\p\artifacts\packages
 Microsoft (R) Build Engine version 16.7.0-preview-20310-07+ee1c9fd0c for .NET
 Copyright (C) Microsoft Corporation. All rights reserved.
 
 C:\h\w\B47C094C\p\tools\dotnet\x64\sdk\5.0.100-preview.7.20319.6\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\B47C094C\p\tools\dotnet\x64\sdk\5.0.100-preview.7.20319.6\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\B47C094C\p\src\tools\Reporting\Reporting\Reporting.csproj]
 
 Build FAILED.
 
 C:\h\w\B47C094C\p\tools\dotnet\x64\sdk\5.0.100-preview.7.20319.6\NuGet.targets(459,5): error MSB4062: The "NuGet.Build.Tasks.GetRestoreProjectStyleTask" task could not be loaded from the assembly C:\h\w\B47C094C\p\tools\dotnet\x64\sdk\5.0.100-preview.7.20319.6\NuGet.Build.Tasks.dll. An attempt was made to load a program with an incorrect format. (0x8007000B) Confirm that the <UsingTask> declaration is correct, that the assembly and all its dependencies are available, and that the task contains a public class that implements Microsoft.Build.Framework.ITask. [C:\h\w\B47C094C\p\src\tools\Reporting\Reporting\Reporting.csproj]
     0 Warning(s)
     1 Error(s)

@DrewScoggins The error occurs only for Reporting.csproj Is there any chance that some of it's dependencies have stopped being available? Or is it some MsBuild bug that we should report?

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 23, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: performance-ci, performance-ci (windows RS5 x64 roslyn master), performance-ci (windows RS5 x64 micro master)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@billwert
Copy link
Contributor

This has to be some MSBuild bug. It worked on 4/5 of the partitions of benchmarks in that leg. If it was a problem with the actual project it should fail on all of them. (And all of our legs, for that matter.)

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 23, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: performance-ci, performance-ci (windows RS5 x64 roslyn master), performance-ci (windows RS5 x64 micro master)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@DrewScoggins
Copy link
Member

I just started a new set of runs to see if we go green or not on those. I also wonder if we can get a good repro to the MSBuild folks from what we have right now.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 23, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: performance-ci, performance-ci (windows RS5 x64 roslyn master), performance-ci (windows RS5 x64 micro master)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@adamsitnik
Copy link
Member

Some other PRs are green, I'll re-run the CI legs and hope that somebody else has reported and fixed the msbuild bug

/azp run

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jun 24, 2020

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: performance-ci, performance-ci (windows RS5 x64 roslyn master), performance-ci (windows RS5 x64 micro master), performance-ci (ubuntu 1804 x64 roslyn release/3.1.3xx), performance-ci (ubuntu 1804 x64 mlnet release/3.1.3xx), performance-ci (ubuntu 1804 x64 roslyn master), performance-ci (ubuntu 1804 x64 mlnet master), performance-ci (ubuntu 1804 x64 micro 2.1), performance-ci (ubuntu 1804 x64 micro release/3.1.3xx), performance-ci (windows RS5 x64 roslyn release/3.1.3xx), performance-ci (ubuntu 1804 x64 micro master), performance-ci (windows RS5 x64 mlnet release/3.1.3xx), performance-ci (windows RS5 x86 micro master), performance-ci (windows RS5 x64 mlnet master), performance-ci (windows RS4 x64 micro_net461 LTS), performance-ci (windows RS5 x64 micro 2.1), performance-ci (windows RS5 x64 micro release/3.1.3xx), performance-ci (windows RS5 x86 sdk_scenarios master), performance-ci (ubuntu 1804 x64 sdk_scenarios master), performance-ci (windows RS5 x64 scenarios 3.0), performance-ci (windows RS5 x64 sdk_scenarios master), performance-ci (windows RS5 x64 scenarios 3.1)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ✔️ Standard Merge Policies Succeeded - No version downgrade detected.

@dotnet-maestro dotnet-maestro bot merged commit a9c9e87 into master Jun 24, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-95df4ed8-5e03-40bd-a429-3a0ce402c3ed branch June 24, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants