Skip to content

[bug] The dotnet/runtime version retrieved for SDK perf scenarios belongs to dotnet/dotnet #4847

@matouskozak

Description

@matouskozak

The dotnet/runtime version retrieved for SDK perf scenarios stopped working since the deployment of VMR.

def get_sdk_versions(dll_folder_path: str, windows_powershell: bool = True) -> dict[str, str]:

The presented version now comes from dotnet/dotnet repo instead of dotnet/runtime repo. That is because in get_sdk_versions we are reading VersionInfo property from the used .dlls but since the dlls are now built as part of dotnet/dotnet they carry the version from there.

As a workaround, the actual dotnet/runtime commit can be retrieved by reading the commitSha from https://github.com/dotnet/dotnet/blob/{dotnet/dotnet_hash}/src/source-manifest.json#L109-L113.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions