Skip to content

LocalhostClusterTest: order lifecycle for smoother runs#9785

Merged
ReubenBond merged 1 commit intodotnet:mainfrom
ReubenBond:fix/localhosttest
Nov 18, 2025
Merged

LocalhostClusterTest: order lifecycle for smoother runs#9785
ReubenBond merged 1 commit intodotnet:mainfrom
ReubenBond:fix/localhosttest

Conversation

@ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Nov 18, 2025

This pull request makes minor improvements to the LocalhostClusterTest method in LocalhostSiloTests.cs, focusing on code clarity and resource management order.

Test setup and cleanup improvements:

  • Changed the array initialization for gateway ports to use the modern C# collection expression syntax for improved readability.
  • Updated the startup sequence to start each silo and the client host sequentially rather than in parallel, which can help with error reporting and debugging.
  • Reordered the shutdown and disposal calls for silos and the client host to ensure a more logical and consistent cleanup sequence.
Microsoft Reviewers: Open in CodeFlow

Copilot AI review requested due to automatic review settings November 18, 2025 00:38
@ReubenBond ReubenBond enabled auto-merge November 18, 2025 00:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the LocalhostClusterTest method by modernizing syntax and establishing a more predictable lifecycle ordering for multi-silo cluster tests.

  • Updated to use C# 13 collection expression syntax for array initialization
  • Changed from parallel to sequential startup to improve debuggability and error reporting
  • Reordered shutdown and disposal to follow proper Orleans cluster lifecycle (client first, then secondary silo, then primary silo)

@ReubenBond ReubenBond added this pull request to the merge queue Nov 18, 2025
Merged via the queue into dotnet:main with commit 6cd76b9 Nov 18, 2025
34 of 35 checks passed
@ReubenBond ReubenBond deleted the fix/localhosttest branch November 18, 2025 01:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant