LocalhostClusterTest: order lifecycle for smoother runs#9785
Merged
ReubenBond merged 1 commit intodotnet:mainfrom Nov 18, 2025
Merged
LocalhostClusterTest: order lifecycle for smoother runs#9785ReubenBond merged 1 commit intodotnet:mainfrom
ReubenBond merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the LocalhostClusterTest method by modernizing syntax and establishing a more predictable lifecycle ordering for multi-silo cluster tests.
- Updated to use C# 13 collection expression syntax for array initialization
- Changed from parallel to sequential startup to improve debuggability and error reporting
- Reordered shutdown and disposal to follow proper Orleans cluster lifecycle (client first, then secondary silo, then primary silo)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to the
LocalhostClusterTestmethod inLocalhostSiloTests.cs, focusing on code clarity and resource management order.Test setup and cleanup improvements:
Microsoft Reviewers: Open in CodeFlow