Do not allocate new buffer if the current buffer is sufficient#9775
Merged
ReubenBond merged 1 commit intodotnet:mainfrom Nov 18, 2025
Merged
Do not allocate new buffer if the current buffer is sufficient#9775ReubenBond merged 1 commit intodotnet:mainfrom
ReubenBond merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an off-by-one error in the EnsureContiguous method that caused unnecessary buffer allocation when the current buffer had exactly the required space available.
Key Changes:
- Changed the boundary check in
EnsureContiguousfrom<to<=to correctly handle the case where_bufferPos + length == _currentSpan.Length
willseward
force-pushed
the
fix-ensure-contig
branch
from
e9f11ab to
999339b
Compare
ReubenBond
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior is that if the currentSpan.Length == buffPos + length, then it will allocate a new buffer. It's not really a problem, but it over-allocates a buffer, when the current one is adequate.
Microsoft Reviewers: Open in CodeFlow