LocalScheduledJobManager: avoid overlapping calls to PeriodicTimer.WaitForNextTickAsync, handle exceptions during shutdown.#9761
Merged
ReubenBond merged 1 commit intodotnet:mainfrom Nov 10, 2025
Conversation
…itForNextTickAsync, handle exceptions during shutdown.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes concurrency issues with PeriodicTimer usage and improves exception handling during shutdown in the LocalScheduledJobManager.
- Prevents overlapping calls to
PeriodicTimer.WaitForNextTickAsyncby capturing and checking task completion state - Adds exception suppression during shutdown for expected
OperationCanceledExceptions - Introduces error recovery delay after exceptions in the periodic check loop
ReubenBond
changed the title
;LocalScheduledJobManager: avoid overlapping calls to PeriodicTimer.WaitForNextTickAsync, handle exceptions during shutdown.LocalScheduledJobManager: avoid overlapping calls to PeriodicTimer.WaitForNextTickAsync, handle exceptions during shutdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlapping calls to
PeriodicTimer.WaitForNextTickAsyncare invalid, so the task needs to be captured and waited on before a subsequent call is made.This also modifies behavior to suppress (largely expected) exceptions during shutdown and inserts a wait after an error occurs.
Microsoft Reviewers: Open in CodeFlow