Attempt to fix flaky test, StatelessWorkerActivationsPerSiloDoNotExceedMaxLocalWorkersCount#9759
Merged
ReubenBond merged 2 commits intodotnet:mainfrom Nov 10, 2025
Conversation
…edMaxLocalWorkersCount
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the StatelessWorkerGrain test grain to use the removeIdleWorkers parameter in the StatelessWorker attribute, setting it to false.
Key Changes
- The
StatelessWorkerGrainattribute now includesremoveIdleWorkers: false, which changes the grain's idle worker cleanup behavior from proactive deactivation to collection age-based deactivation.
…ceedMaxLocalWorkersCount_
ReubenBond
deleted the
fix/StatelessWorkerActivationsPerSiloDoNotExceedMaxLocalWorkersCount_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks like a test issue at first glance, caused by Orleans cleaning up idle workers every 500ms (the test includes a 2s pause)
Microsoft Reviewers: Open in CodeFlow