Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the development container configuration and refines a return type in the Orleans runtime for improved type specificity.
- Updated devcontainer configuration from custom Dockerfile to modern features-based approach
- Changed
ActivationTaskSchedulerproperty return type from baseTaskSchedulerto the more specificActivationTaskSchedulertype - Removed legacy Azure CLI installation script that's no longer needed
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Orleans.Runtime/Catalog/ActivationData.cs | Changed ActivationTaskScheduler property return type to be more specific (from TaskScheduler to ActivationTaskScheduler) |
| .devcontainer/devcontainer.json | Modernized to use official dotnet devcontainer image with features (docker-in-docker, github-cli) instead of custom Dockerfile |
| .devcontainer/Dockerfile | Removed obsolete custom Dockerfile that's replaced by official image |
| .devcontainer/library-scripts/azcli-debian.sh | Removed obsolete Azure CLI installation script |
ReubenBond
force-pushed
the
update/devcontainer
branch
from
6bdc9ec to
29a89a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the devcontainer to latest .NET and clean up. I took inspiration from the dotnet/aspire devcontainer.
Microsoft Reviewers: Open in CodeFlow