[Journaling] Align status serialization for both read and write in DurableTaskCompletionSource#9626
Merged
ReubenBond merged 1 commit intodotnet:mainfrom Jul 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DurableTaskCompletionSourcehas a serialization bug where the status gets written as a byte but read back as a VarUInt32. This can leave the buffer reader misaligned for subsequent reads of the result / exception payload(s), causing an insufficient data exception.This change aligns both operations to use ReadByte/WriteByte, ensuring the Reader advances predictably.
Microsoft Reviewers: Open in CodeFlow