Use UTC DateTime instead of DateTimeOffset in IAmAliveTime comparison #9341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGMT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #9303 I added an internal EffectiveIAmAliveTime to incorporate the
StartTimeandIAmAliveTimeinto a single property returning the maximum. The property was typedDateTimeOffsetbut when comparing to theDateTimevalues returned from some membership providers (such as ADO.NET with SqlClient), the stored value was being retrieved with an unspecifiedDateTimeKindand this caused it to be treated as a local time, causing warnings such as:13:44:41:507 [WRN] [MembershipTableManager ] Noticed that silo xxx.xxx.xxx.xxx:11122:98364351 has not updated it's IAmAliveTime table column recently. Last update was at 12-2-2025 12:44:25 +01:00, now is 12-2-2025 12:44:41, no update for 01:00:16.3675547, which is more than 00:01:30.This PR changes that property to a
DateTimeinstead and treats theStartTimeandIAmAliveTimeproperties as though they were UTC times.Microsoft Reviewers: Open in CodeFlow