Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build only one configuration in Build.cmd #3443

Merged
merged 2 commits into from
Sep 26, 2017
Merged

Build only one configuration in Build.cmd #3443

merged 2 commits into from
Sep 26, 2017

Conversation

jdom
Copy link
Member

@jdom jdom commented Sep 26, 2017

Build only 1 configuration instead of both Debug and Release in Build.cmd
Default local development environment to Debug, but CI environment to Release.

@jdom
Build only one configuration in Build.cmd
e218169 
Build only 1 configuration instead of both Debug and Release in Build.cmd
Default local development environment to Debug, but CI environment to Release.
@jdom jdom requested review from ReubenBond and attilah September 26, 2017 00:45
@jdom
Copy link
Member Author

jdom commented Sep 26, 2017

@dotnet-bot test ci please

@benjaminpetit
Copy link
Member

It seems that in CI it build Debug instead of Release, and xunit is only expecting dlls in the Release subfolder of the projects.

It could be nice too to be able to launch the test on debug?

@jdom
Copy link
Member Author

jdom commented Sep 26, 2017

@dotnet-bot test this please
Reason: Yes, the groovy file change did not kick in yet, that's why I tested CI first, and now we should be able to run the modified CI with the change that sets BuildConfiguration to Release

@jdom
Copy link
Member Author

jdom commented Sep 26, 2017

@dotnet-bot test GenPRTest/bvt_prtest

@jdom
Copy link
Member Author

jdom commented Sep 26, 2017

@benjaminpetit yup, I missed that, thanks, we should be able to run tests in the specified (or default) build configuration.

Also, this is a run with the updated groovy file that runs in release mode:
BVT: https://ci.dot.net/job/dotnet_orleans/job/master/job/GenPRTest/job/bvt_prtest/2/
Functional: https://ci.dot.net/job/dotnet_orleans/job/master/job/GenPRTest/job/functional_prtest/1/

@jdom
Copy link
Member Author

jdom commented Sep 26, 2017

The temporary jobs building in Release mode where deleted (the CI builds expires after a few hours), but they built and tested the Release configuration successfully.

attilah
attilah approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@attilah attilah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attilah attilah merged commit 4736a3c into dotnet:master Sep 26, 2017
attilah pushed a commit to attilah/orleans that referenced this pull request Sep 26, 2017
@jdom
Build only one configuration in Build.cmd (dotnet#3443)
fb68111 
* Build only one configuration in Build.cmd

Build only 1 configuration instead of both Debug and Release in Build.cmd
Default local development environment to Debug, but CI environment to Release.

* Allow running tests in Debug configuration
@jdom jdom deleted the build-configuration branch September 27, 2017 23:55
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@attilah attilah attilah approved these changes

@ReubenBond ReubenBond Awaiting requested review from ReubenBond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdom @benjaminpetit @attilah @dnfclas