Remove Legacy build flavor from all over the tree #3415
Conversation
Directory.Build.props
Outdated
| <PropertyGroup Condition=" '$(BuildFlavor)' == 'Legacy' "> | ||
| <VersionPrefix Condition=" '$(VersionPrefix)'=='' ">1.6.0</VersionPrefix> | ||
| <VersionSuffix Condition=" '$(VersionSuffix)'=='' "></VersionSuffix> | ||
| <VersionSuffix Condition=" '$(VersionSuffix)'=='' ">preview4</VersionSuffix> |
There was a problem hiding this comment.
please don't update this, since we will probably not update the preview number, just the build number (the date), unless we have bigger breaking changes
| sb.Append(" .NET version: ").AppendLine(Environment.Version.ToString()); | ||
| sb.Append(" OS version: ").AppendLine(Environment.OSVersion.ToString()); | ||
| sb.Append(" App config file: ").AppendLine(AppDomain.CurrentDomain.SetupInformation.ConfigurationFile); |
There was a problem hiding this comment.
I'd leave the conditional compilation (although just around this line) if we didn't solve this yet, as a reminder of stuff we need to do before release (either decide to kill this or have some other way of troubleshooting, since it's not always straightforward to know which config file Orleans chose in some weird deployment cases)
There was a problem hiding this comment.
If the host runs full .net it has access to this class and property and can be logged when troubleshooting.
Since we're compiling against .Net Standard 2.0 we do not so I don't see the value of keeping the #if here, but of course if you insist I can add that back, please advise.
| @@ -60,146 +56,6 @@ public EHPurgeLogicTests() | |||
| this.logger = new NoOpTestLogger().GetLogger(this.GetType().Name); | |||
| } | |||
|
|
|||
| //Disable tests if in netstandard, because Eventhub framework doesn't provide proper hooks for tests to generate proper EventData in netstandard | |||
| #if BUILD_FLAVOR_LEGACY | |||
There was a problem hiding this comment.
@xiazen @jason-bragg can you validate if removing these is the right call now that we are fully migrating to the new package? Maybe they provide the hooks now?
There was a problem hiding this comment.
please don't delete those tests. if they doesn't pass because netstandard, you can disable or comment them for now. I will come back and fix them.
|
@dotnet-bot test this please |
Remove OrleansHost project and tests Cleanup csproj, targets and props files to have only the current information Fix missing or wrong xml comments Bump version to 2.0.0 preview 4 Enable warning as error for the solution as default
…nabled, but blocked this PR.
attilah
force-pushed
the
legacy-remove
branch
from
95ee5a6 to
89559cd
Compare
Remove OrleansHost project and tests
Cleanup csproj, targets and props files to have only the current information
Fix missing or wrong xml comments
Bump version to 2.0.0 preview 4
Enable warning as error for the solution as default