Skip to content
This repository was archived by the owner on May 2, 2024. It is now read-only.

Conversation

@ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 10, 2022

Contributes to dotnet/runtime#66447

Remove the VersionPrefix property so that it is inferred from the Versions.props versions (MajorVersion, MinorVersion, PatchVersion) which is the Arcade default behavior. This will cause the package version to bump to 7.0.0-....

I'm also changing the feeds to that the transport package now pushes into the dotnet7-transport feed instead of dotnet6-transport.

Remove the VersionPrefix property so that it is inferred from the Versions.props ProductVersion.
@ViktorHofer ViktorHofer requested a review from a team March 10, 2022 11:00
@ViktorHofer ViktorHofer self-assigned this Mar 10, 2022
@ViktorHofer
Copy link
Member Author

The build fails with

  CMake Error at CMakeLists.txt:40 (project):
    Generator
  
  -- Configuring incomplete, errors occurred!
  See also "D:/a/1/s/src/msquic/build/windows/x64_schannel/CMakeFiles/CMakeOutput.log".
      Visual Studio 16 2019
  
    could not find any instance of Visual Studio.
  
  
  
  CMake-Execute: D:\a\1\s\src\msquic\scripts\build.ps1:403

That error is unrelated. Is this repo's CI currently broken?

@ManickaP
Copy link
Member

Looks like it was fine yesterday based on @wfurt PR. I guess it's actions/runner-images#4856 and update to newer Windows and with this newer VS. Possible solution: use older windows-2019 pool or upgrade build scripts.
I'll look into it tomorrow unless someone fixes it in the meantime.

@nibanks
Copy link

nibanks commented Mar 10, 2022

Yes, you need to consume the latest MsQuic to work on 2022, otherwise use 2019 for the time being.

@ManickaP
Copy link
Member

I merged @wfurt PR, that should help here.

@ViktorHofer ViktorHofer merged commit 4fe73fc into main Mar 10, 2022
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-1 branch March 10, 2022 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants