Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 17.10.2 #9994

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Apr 11, 2024

Context

Insertion for VS was generated for the wrong target branch.
The attempt to run it manually for the proper target fails due to package conflicts:
https://dev.azure.com/devdiv/DevDiv/_releaseProgress?releaseId=1522691&_a=release-pipeline-progress

We need to generate a new package for VS rel/d17.10

@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner April 11, 2024 07:13
Copy link
Contributor

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

@YuliiaKovalova YuliiaKovalova enabled auto-merge (squash) April 11, 2024 07:20
@YuliiaKovalova YuliiaKovalova merged commit d08d5e4 into dotnet:vs17.10 Apr 11, 2024
9 checks passed
surayya-MS added a commit that referenced this pull request Apr 11, 2024
* Translation update from OneLocBuild (#9963)

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9347357

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9347357

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9394753

* Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 9394753

* Remove spurious `Ł` character in Italian version string

---------

Co-authored-by: Rainer Sigwald <raines@microsoft.com>

* Dispose AssemblyInformation in GetAssembliesMetadata (#9974)

Fixes AB#2017198 by releasing the handle to the file by disposing the AssemblyInformation deterministically.

* Update package version to 17.10.2 (#9994)

---------

Co-authored-by: dotnet bot <dotnet-bot@dotnetfoundation.org>
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Co-authored-by: YuliiaKovalova <95473390+YuliiaKovalova@users.noreply.github.com>
Co-authored-by: Surayya Huseyn Zada <shuseynzada@microsoft.com>
@rainersigwald
Copy link
Member

For the future: as long as it's really the same build, you can bypass the nuget push steps on a retry attempt. They are set up to fail in order to catch the case where we accidentally run another build with the same version.

This was fine though, no harm in the version bump!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants