Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add escape hatch MSBUILDCOPYWITHOUTDELETE #9257

Merged

Conversation

rainersigwald
Copy link
Member

Work item (Internal use): N/A

Summary

This allows an opt-in workaround for #9250 that affected deployment processes can use, mitigating the risk of entirely reverting #8685.

Customer Impact

Automated deployment of new versions of apps failed in some environments.

Regression?

Yes, from #8685 (in 7.0.400/MSBuild 17.7).

Testing

Tests in the affected environment using the more-broadly-scoped MSBUILDDISABLEFEATURESFROMVERSION=17.8 pass.

Risk

Minimal--adds new scoped opt-out that is redundant with known successful opt-out, using established mechanisms.

This allows an opt-in workaround for dotnet#9250 that affected deployment
processes can use, mitigating the risk of entirely reverting dotnet#8685.
@ghost
Copy link

ghost commented Sep 22, 2023

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

Copy link
Member

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More granular flag looks good.

@rainersigwald
Copy link
Member Author

Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version.

The first 17.8.0 build failed because of missing optprof data for the vs17.8 branch, so there's no package with stable branding yet and we can disregard this policy this time.

@rainersigwald rainersigwald merged commit 6cdef42 into dotnet:vs17.8 Sep 22, 2023
8 checks passed
@rainersigwald rainersigwald deleted the quirk-for-delete-before-copy branch September 22, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants