Fixed the embedded file size record #9065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladipro
reviewed
Jul 25, 2023
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
KirillOsenkov
approved these changes
Jul 25, 2023
ladipro
approved these changes
Jul 26, 2023
This was referenced Jul 29, 2025
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug introduced by #8971
Work item (Internal use):
Summary
Size of the payload was incorrectly written as Int64, which causes corruption of the binary log format.
Customer Impact
Customers are not able to diagnose build problems at full capacity.
Testing
New unit test was introduced to prevent regression.
Risk
low - adds check that is unlikely to fail since the size limit matches the previous one