Skip to content

Comment for #9035 #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Comment for #9035 #9040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/MSBuild/LiveLogger/Terminal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ namespace Microsoft.Build.Logging.LiveLogger;
internal sealed class Terminal : ITerminal
{
/// <summary>
/// The encoding read from <see cref="Console.OutputEncoding"/> when the terminal is instantiated.
/// The encoding read from <see cref="Console.OutputEncoding"/> when the terminal is constructed.
/// </summary>
private readonly Encoding _originalOutputEncoding;

Expand Down Expand Up @@ -67,6 +67,10 @@ public Terminal()
_originalOutputEncoding = Console.OutputEncoding;
Console.OutputEncoding = Encoding.UTF8;

// Capture the TextWriter AFTER setting the encoding, because setting
// the encoding creates a new TextWriter in the Console class, but it's
// possible to hang on to the old one (with the wrong encoding) and emit
// garbage, as in https://github.com/dotnet/msbuild/issues/9030.
Output = Console.Out;
}

Expand Down