Change WriteCodeFragment task to create directory

[jrdodds]

Fixes #8516

Context

Setting an OutputDirectory where the directory does not exist, and setting an OutputFile would fail.

(Setting an OutputDirectory where the directory does not exist, and not providing an OutputFile value would succeed because FileUtilities.GetTemporaryFile calls Directory.CreateDirectory.)

Changes Made

WriteCodeFragment_Tests.cs

• Added new unit tests:
  • CombineFileDirectoryAndDirectoryDoesNotExist (pairs with CombineFileDirectory)
  • ToDirectoryAndDirectoryDoesNotExist (pairs with ToDirectory)
• Added overload of CreateTask

WriteCodeFragment.cs

• Changed task to call FileUtilities.EnsureDirectoryExists.

Testing

Added unit tests first and confirmed failure.

Ran all unit tests on Windows 11 and macOS 12 (Monterey).

Notes

[Forgind]

Looks good to me!

[Forgind]

Why did this test work on Unix before?

[jrdodds]

It worked before because the path didn't exist. Now that we ensure that the path is created, the test fails because there is not an MSB3713 error as the test expects. 😀

[Forgind]

Ah, looks like 3713 is a very generic error for any failure after our initial validation. Makes sense, thanks!

[jrdodds]

Off-topic except that I saw the problem while working on this issue:
The unit test Microsoft.Build.UnitTests.Construction.SolutionProjectGenerator_Tests.BuildProjectWithMultipleTargetsInParallel is sometimes failing on macOS, but it is not consistent. The failure is at line 262 in the following snippet:

msbuild/src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs

Lines 261 to 262 in 4ffba3f

	var output = RunnerUtilities.ExecMSBuild(solutionFile.Path + " /m /t:Clean;Build;Custom", out bool success);
	success.ShouldBeTrue();

[rainersigwald]

Awesome, thanks!