Skip to content

Conversation

@Forgind
Copy link
Contributor

@Forgind Forgind commented Jan 9, 2023

Lot less to do without the build status messages!

Do you think we should update the PackageValidationBaselineVersion to 17.5.0?

@rainersigwald
Copy link
Member

Do you think we should update the PackageValidationBaselineVersion to 17.5.0?

We can't, because it doesn't exist. We could update to 17.5.0-previewXXXXX, and I proposed doing that in #8116 (comment).

@Forgind
Copy link
Contributor Author

Forgind commented Jan 9, 2023

Do you think we should update the PackageValidationBaselineVersion to 17.5.0?

We can't, because it doesn't exist. We could update to 17.5.0-previewXXXXX, and I proposed doing that in #8116 (comment).

Good point. Is there any reason it's better to update to 17.5-preview now, as opposed to just waiting until 17.5.0 is available? It would protect us if we change an API we'd just added, but it seems ok to me to have our errors for that be slightly delayed.

@rainersigwald
Copy link
Member

It would protect us if we change an API we'd just added

Yeah I think that's the biggest thing, and seems worth the cost to me.

@Forgind
Copy link
Contributor Author

Forgind commented Jan 9, 2023

Do we know what channel it looks at to find the version of MSBuild it requests? I vaguely remembered it pulling from nuget.org, at least as an option. I'm wondering how to see which preview versions are available.

@rainersigwald
Copy link
Member

It'll look at these:

msbuild/NuGet.config

Lines 5 to 8 in ab3d68e

<add key="arcade" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
<add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
<add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
<add key="dotnet6" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json" />

and dotnet-tools is the relevant one:

https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-tools/NuGet/Microsoft.Build/versions/17.5.0-preview-23059-01

@Forgind
Copy link
Contributor Author

Forgind commented Jan 9, 2023

Sounds good! Thanks for finding that. I pushed the change.

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 17, 2023
@JaynieBai JaynieBai merged commit 2df8ecd into dotnet:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants