Nuked ThreadingUtilities.cs

[khellang]

This file does not compile and is clearly not used anywhere 😕

[akoeplinger]

Corresponding issue: #4

[dannyvv]

lgtm: 👍

[AndyGerlicher]

LGTM!

[knocte]

I suggest that the why (not just the what) is kept in commit messages as well as PullRequest descriptions. Otherwise people looking at git history will not understand some changes.

[khellang]

@knocte If you want everyone to understand all changes done to a project, I don't think it's enough with commit messages. The PR clearly states why.

[akoeplinger]

@khellang sure, but if I'm looking at this commit from something else than github, I don't get the link to the PR it comes from. Putting the description into the commit message helps there.

[knocte]

Exactly, there's a link from the PR to the commit, but not the other way around.

[akoeplinger]

@knocte just FYI, GitHub actually links to the PR from the commit:

[khellang]

GitHub does link to the PR, and there's a merge commit in the history that has a link to it.

It even shows from forks:

Here's the merge commit: e96e44d

I'm not saying that commits shouldn't have the why included, but it's too late for me to do anything about it now. I'd rather not rebase master and do another PR 😉

[knocte]

I'm not saying that commits shouldn't have the why included, but it's too late for me to do anything about it now.

I know, I'm just advicing for next commits.

@knocte just FYI, GitHub actually links to the PR from the commit

Github yes, but not git. Sometimes I use gitk to examine history, for example, as it's way faster.