Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more params to the evaluation pass stops #5978

Merged
merged 1 commit into from
Dec 18, 2020

Conversation

arunchndr
Copy link
Member

No description provided.

@dnfadmin
Copy link

dnfadmin commented Dec 18, 2020

CLA assistant check
All CLA requirements met.

@dnfadmin
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ arkalyanms sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. This will help contextualize the elapsed-time numbers!

@arunchndr arunchndr merged commit a971ecd into master Dec 18, 2020
@arunchndr arunchndr deleted the dev/arkalyan/add-logging-params branch December 18, 2020 22:31
@@ -624,7 +624,7 @@ private void Evaluate()
}

_data.InitialTargets = initialTargets;
MSBuildEventSource.Log.EvaluatePass1Stop(projectFile);
Copy link
Member

@Forgind Forgind Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is accurate because _projectRootElement.Properties does not include properties of imported projects. See here and note that ProjectImportElements are not ProjectElementContainers.

Also, since it does a nontrivial amount of work, please surround it with an IsEnabled check. As-is, this will worsen solution load time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ProjectImportGroupElement is a ProjectElementContainer and that should get included in both the Properties recursion as it is with the PerformDepthFirstPass recursion. Also the Count is a property get on an already instantiated ReadOnlyCollection (as a part of the actual evaluation above the log). No?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this offline, but ProjectImportElement is not a ProjectElementContainer so isn't included, and accessing the Properties ReadOnlyCollection constructs it as needed, hence the perf hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants