Update 16.7 error message when trying to use net5.0 #5826
Conversation
src/Tasks/Resources/Strings.resx
Outdated
| @@ -2160,7 +2160,11 @@ | |||
| <value>MSB3645: .NET Framework v3.5 Service Pack 1 was not found. In order to target "{0}", .NET Framework v3.5 Service Pack 1 or later must be installed.</value> | |||
| <comment>{StrBegin="MSB3645: "}</comment> | |||
| </data> | |||
|
|
|||
| <data name="GetReferenceAssemblyPaths.ReferenceAssemblyNotSupported"> | |||
| <value>MSB3646: The discovered assembly "{0}" is not supported with this version of Visual Studio. To resolve this, retarget your application or update Visual Studio. You can download the latest version of Visual Studio at http://aka.ms/vsdownload</value> | |||
There was a problem hiding this comment.
NOTE: To get this in, we'd need a one-off localization pass for this new string. cc @wli3
src/Tasks/Resources/Strings.resx
Outdated
| @@ -2160,7 +2160,11 @@ | |||
| <value>MSB3645: .NET Framework v3.5 Service Pack 1 was not found. In order to target "{0}", .NET Framework v3.5 Service Pack 1 or later must be installed.</value> | |||
| <comment>{StrBegin="MSB3645: "}</comment> | |||
| </data> | |||
|
|
|||
| <data name="GetReferenceAssemblyPaths.OutOfDateSDK"> | |||
| <value>MSB3961: The reference assemblies for "{0}" were not found. You might be using an older SDK to target .NET 5.0 or higher. Update Visual Studio and/or your .NET SDK.</value> | |||
There was a problem hiding this comment.
Updating VS right now would mean updating to 16.7. They would have to switch to a preview version, right?
There was a problem hiding this comment.
This will ship after or at best concurrently with 16.8.
There was a problem hiding this comment.
Also, this is specifically for customers who are using 16.7 and building a project that targets 5.0. They are specifically not using 16.8 (preview or otherwise). They got the project from a coworker or retargeted themselves, etc. We already have customers reporting this who installed 5.0 previews on top of 16.7 and tried to make it work.
There was a problem hiding this comment.
@KathleenDollard to review the string.
There was a problem hiding this comment.
Just wanted to note that you can hit this with 16.8 if you global.json yourself down to a 3.1 or lower SDK.
PR feedback Co-authored-by: Daniel Plaisted <dsplaisted@gmail.com>
|
Remember to update the version number to 16.7.2...never mind, looks like you already did. |
|
The issue created to discuss the breaking change has been closed, as this fix does not impact that scenario. See here: #5833 (comment) |
|
Note to self: This should not flow into the sdk. Need to change branding for December release. |
Description
MSBuild currently gives a bad error message when using older .NET Core sdk's and targeting
net5.0. The error message is not helpful so we want to update it for that specific scenario.Customer Impact
Customers using an older SDK and targeting
net5.0currently receive an error that does not help their scenario. This PR fixes that message.Risk
Low. We've acknowledged that this change will break legacy UWP projects that target
netcore50, and are okay with that. The discussion for that is located here: #5833. Based on telemetry there seem to be somewhere between 1~4 users that would hit this scenario.Code Reviewers
@Forgind
@rainersigwald
Description of fix
Change the error message when the discovered assembly is
net5.0and we're on an older SDK.Fixes #5820
Resource Name:
GetReferenceAssemblyPaths.OutOfDateSDKOld bad message:
The reference assemblies for {0} were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacksNew good message (when targeting net5.0 and using an older SDK:
The reference assemblies for "{0}" were not found. You might be using an older SDK to target .NET 5.0 or higher. Update Visual Studio and/or your .NET SDK.