Use a counter instead of relying in XPathNodeIterator.Count #5665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add a unit test? |
|
Sure, @danmosemsft, This was done right in GitHub. Adding a test will require a bit more work. Where should I add the test? This will be my first MSBuild Task unit test. Any model I can follow? |
|
Done! |
|
I'll do the changes, they are out of scope, but I'll do them. Do you want Shouldly to be used on the entire test class or only on the added test method? |
|
@paulomorgado Only the added test method. Much appreciated! |
|
Done! |
cdmihai
approved these changes
Aug 21, 2020
benvillalobos
approved these changes
Aug 21, 2020
rainersigwald
approved these changes
Aug 28, 2020
|
Thanks! |
paulomorgado
added a commit
to paulomorgado/dotnet-msbuild
that referenced
this pull request
Aug 28, 2020
Followup from dotnet#5665
paulomorgado
added a commit
to paulomorgado/dotnet-msbuild
that referenced
this pull request
Aug 29, 2020
Followup from dotnet#5665
paulomorgado
added a commit
to paulomorgado/dotnet-msbuild
that referenced
this pull request
Aug 30, 2020
Followup from dotnet#5665
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2051