-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Force content copying to either be recursive, 1-level, or legacy #4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7ec9c5 to
0f6742b
Compare
2b9cce5 to
ef07952
Compare
… GetCopyToOutputDirectoryItems
ef07952 to
c524a47
Compare
152169f to
66ea994
Compare
rainersigwald
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4677
Fixes #1054
This turned out to be more complicated than it should be in order to maintain backwards compatibility with legacy behaviour (described in #4677). For example, quickbuild depends on this bug and fixing it will take some time and it's probably low priority, so the ability to pin the bad behaviour and fix later is sadly okay here.
Feedback needed on:
$(MSBuildCopyContentTransitively )wheretruemeans transitive,falsemeans 1-level copying, nothing means legacy (which should be the same asfalse). Would you rather I named the values totransitive,1-level,legacyand set it tolegacyby default?BuildProjectReferences=false, seems like VS should test for this. Quickbuild will also test for this if it turns/isolateby default in its builds. Or I could add it to the Microsoft.Net.Sdk tests, if it wants to care aboutBuildProjectReferences=false