dir.targets: correctly enclose 'Exists' condition in single quotes #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to MSDN (http://msdn.microsoft.com/en-us/library/7szfhaft.aspx), the single quotes can be left off for "simple alphanumeric strings or boolean values". This is not the case here (it is a property), so we should use single quotes. Note that MSBuild ignores this, but it results in a parser error on Mono's xbuild.
Member
Author
|
And yes, I'm aware how ironic it is to build MSBuild with xbuild 😄 |
Member
|
lgtm: 👍 |
Contributor
|
👍 |
AndyGerlicher
added a commit
that referenced
this pull request
Mar 18, 2015
Changing Build.Utilities back to Build.Utilities.Core
radical
referenced
this pull request
in radical/msbuild
Feb 1, 2017
We need to set `/p:RuntimeSystem=` on Linux, but this value is set on line 204 then overwritten with something else on line 234
AndyGerlicher
pushed a commit
to AndyGerlicher/msbuild
that referenced
this pull request
Feb 17, 2017
Add support for custom SDK Location. When there is property TargetPlatformSdkRootOverride defined in project, we set TargetPlatformSdkPath to same value to redirect it to custom SDK location. Otherwise building project for release mode will fail.
radical
referenced
this pull request
in radical/msbuild
Jun 23, 2017
git@github.com:xamarin/xamarin-iot.git 6c570d5c7ade7ffc9b647f453832eee7d27ed37e `src/IDE/Sdks/Xamarin.IoT.Sdk/` after make
AR-May
added a commit
that referenced
this pull request
Apr 1, 2021
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Jun 28, 2021
ladipro
added a commit
to ladipro/msbuild
that referenced
this pull request
Jun 29, 2021
This reverts commit d938e8d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to MSDN (http://msdn.microsoft.com/en-us/library/7szfhaft.aspx), the
single quotes can be left off for "simple alphanumeric strings or boolean values".
This is not the case here (it is a property), so we should use single quotes.
Note that MSBuild ignores this, but it results in a parser error on Mono's xbuild.