Repository navigation
Call out MSBUILD_LOGGING_ARGS - #14641
Merged
Merged
Conversation
I was looking at this doc to confirm the spelling of the new environment variable, but it's not mentioned in the doc until way further down the page.
rainersigwald
temporarily deployed
to
copilot-pat-pool
August 4, 2026 20:10 — with
GitHub Actions
Inactive
rainersigwald
enabled auto-merge (squash)
August 4, 2026 20:10
rainersigwald
temporarily deployed
to
copilot-pat-pool
August 4, 2026 20:11 — with
GitHub Actions
Inactive
rainersigwald
temporarily deployed
to
copilot-pat-pool
August 4, 2026 20:11 — with
GitHub Actions
Inactive
baronfel
approved these changes
Aug 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Surfaces the MSBUILD_LOGGING_ARGS environment variable earlier in the spec so readers can quickly confirm the exact name/spelling without scanning further down the document.
Changes:
- Updates the “Proposed solution” line to explicitly name
MSBUILD_LOGGING_ARGS. - Fixes/normalizes a markdown code fence at the end of the document.
rainersigwald
temporarily deployed
to
copilot-pat-pool
August 4, 2026 20:15 — with
GitHub Actions
Inactive
rainersigwald
temporarily deployed
to
copilot-pat-pool
August 4, 2026 20:18 — with
GitHub Actions
Inactive
Contributor
There was a problem hiding this comment.
✅ 24/24 dimensions clean — no findings. Documentation-only change. The env var name MSBUILD_LOGGING_ARGS is confirmed correct — it matches implementation in src/Framework/Traits.cs, CommandLineParser.cs, and tests. Both changes (surfacing the env var name earlier + adding trailing newline) are accurate and helpful.
Generated by Expert Code Review (on open) for #14641 · sonnet46 · 32.9 AIC · ⌖ 7.47 AIC · ⊞ 5.2K
rainersigwald
temporarily deployed
to
copilot-pat-pool
August 4, 2026 20:18 — with
GitHub Actions
Inactive
And Rainer agrees Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
baronfel
approved these changes
Aug 4, 2026
This was referenced Oct 16, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at this doc to confirm the spelling of the new environment variable, but it's not mentioned in the doc until way further down the page.