Skip to content

Call out MSBUILD_LOGGING_ARGS - #14641

Merged
rainersigwald merged 2 commits into
mainfrom
rainersigwald-patch-1
Aug 4, 2026
Merged

rainersigwald merged 2 commits into
mainfrom
rainersigwald-patch-1

Conversation

@rainersigwald

Copy link
Copy Markdown
Member

I was looking at this doc to confirm the spelling of the new environment variable, but it's not mentioned in the doc until way further down the page.

I was looking at this doc to confirm the spelling of the new environment variable, but it's not mentioned in the doc until way further down the page.
Copilot AI review requested due to automatic review settings August 4, 2026 20:10
@rainersigwald
rainersigwald enabled auto-merge (squash) August 4, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Surfaces the MSBUILD_LOGGING_ARGS environment variable earlier in the spec so readers can quickly confirm the exact name/spelling without scanning further down the document.

Changes:

  • Updates the “Proposed solution” line to explicitly name MSBUILD_LOGGING_ARGS.
  • Fixes/normalizes a markdown code fence at the end of the document.

Comment thread documentation/specs/enable-binlog-collection-by-env-var.md Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 24/24 dimensions clean — no findings. Documentation-only change. The env var name MSBUILD_LOGGING_ARGS is confirmed correct — it matches implementation in src/Framework/Traits.cs, CommandLineParser.cs, and tests. Both changes (surfacing the env var name earlier + adding trailing newline) are accurate and helpful.

Generated by Expert Code Review (on open) for #14641 · sonnet46 · 32.9 AIC · ⌖ 7.47 AIC · ⊞ 5.2K

And Rainer agrees

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants