Mimic Full Framework string quoting #1369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmihai
force-pushed
the
issue1294/assemblyInfo
branch
from
3bd6357 to
e609bdc
Compare
CodeDom is not available on .net core, so copy over its string quoting implementation. Ideally, all this code should be replaced with crossplatform Roselyn Fixes dotnet#1294
cdmihai
force-pushed
the
issue1294/assemblyInfo
branch
from
e609bdc to
7129454
Compare
AndyGerlicher
approved these changes
Nov 22, 2016
rainersigwald
approved these changes
Nov 22, 2016
There was a problem hiding this comment.
I think this'd read clearer if it was just "\\r\\n" : "\\n" instead of the concatenation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeDom is not available on .net core, so copy over its string quoting implementation.
Ideally, all this code should be replaced with crossplatform Roselyn
Fixes #1294