Skip to content

Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents #13509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanProvaznik merged 2 commits into from
Apr 13, 2026
Merged

Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents #13509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67a1b10
Eliminate XmlChildNodes allocations in GetXmlNodeInnerContents
nareshjo Apr 9, 2026
0d0c5e5
use is null instead of == as per PR feedback
nareshjo Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Build/Utilities/Utilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,21 @@ internal static string GetXmlNodeInnerContents(XmlElementWithLocation node)

// XmlNode.InnerXml is much more expensive than InnerText. Don't use it for trivial cases.
// (single child node with a trivial value or no child nodes)
if (!node.HasChildNodes || (node.ChildNodes.Count == 1 && node.FirstChild.NodeType == XmlNodeType.Whitespace))
// Avoid accessing node.ChildNodes -- it allocates a new XmlChildNodes wrapper on every call.
// Use FirstChild/NextSibling linked-list traversal instead (allocation-free).
XmlNode firstChild = node.FirstChild;
if (firstChild is null)
{
return String.Empty;
}

if (node.ChildNodes.Count == 1 && (node.FirstChild.NodeType == XmlNodeType.Text || node.FirstChild.NodeType == XmlNodeType.CDATA))
bool isSingleChild = firstChild.NextSibling is null;
if (isSingleChild && firstChild.NodeType == XmlNodeType.Whitespace)
{
return String.Empty;
}

if (isSingleChild && (firstChild.NodeType == XmlNodeType.Text || firstChild.NodeType == XmlNodeType.CDATA))
{
return node.InnerText;
}
Expand Down