-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add fallback behavior for Microsoft.DotNet.MsBuildSdkResolver loading in external API scenarios #12703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huulinhnguyen-dev
wants to merge
8
commits into
dotnet:main
Choose a base branch
from
huulinhnguyen-dev:dev/huulinhnguyen/fail-to-resolve-MsBuildSdkResolver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+146
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in external API scenarios
AR-May
reviewed
Oct 29, 2025
src/Build/BackEnd/Components/SdkResolution/SdkResolverLoader.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/SdkResolution/SdkResolverLoader.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/SdkResolution/SdkResolverLoader.cs
Outdated
Show resolved
Hide resolved
…https://github.com/huulinhnguyen-dev/msbuild into dev/huulinhnguyen/fail-to-resolve-MsBuildSdkResolver
d09e1d3 to
50d9905
Compare
6d951d8 to
8a4c5dd
Compare
a3ff673 to
ec2dca6
Compare
SimaTian
reviewed
Nov 10, 2025
SimaTian
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Fix the issue: Could not load file or assembly
Microsoft.DotNet.MsBuildSdkResolver#12578Context
External API users were experiencing failures when loading Microsoft.DotNet.MSBuildSdkResolver because Assembly.Load with CodeBase was failing. This caused SDK resolution to fail for external tools and applications.
Changes Made
Testing
Notes
This change improves compatibility for external API users while maintaining the existing behavior for Visual Studio users. The fallback ensures that SDK resolution works in more scenarios without breaking VS functionality.