[vs17.12] Merge v17.12.50 into vs17.12#12649
Merged
rainersigwald merged 2 commits intodotnet:vs17.12from Oct 17, 2025
Merged
Conversation
…bdirectory on every build Recreate temp on linux using CreateTempSubdirectory on every build ---- #### AI description (iteration 2) #### PR Classification This PR is a security fix addressing vulnerabilities in temporary folder creation on Linux. #### PR Summary The PR revises the MSBuild temporary folder creation by replacing custom mkdir/chmod logic with a secure API call to Directory.CreateTempSubdirectory on Linux, mitigating risks of malicious folder pre-creation. It also bumps the package version. - `src/Shared/TempFileUtilities.cs`: Replaces custom Linux temp folder creation logic with a call to Directory.CreateTempSubdirectory and adjusts the fallback branch. - `src/Shared/TempFileUtilities.cs`: Removes the obsolete userRWX constant. - `eng/Versions.props`: Updates the version prefix from 17.12.49 to 17.12.50. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #2541147
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges tag v17.12.50 into the vs17.12 branch, updating the version number and refactoring temporary file directory creation on Linux to use built-in .NET functionality.
Key Changes:
- Version bump from 17.12.49 to 17.12.50
- Simplified Linux temp folder creation by replacing custom native calls with
Directory.CreateTempSubdirectory() - Removed complex security checks and fallback logic that are now handled by the framework
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| eng/Versions.props | Updates version prefix from 17.12.49 to 17.12.50 |
| src/Shared/TempFileUtilities.cs | Simplifies temp directory creation on Linux using framework API instead of manual native calls |
YuliiaKovalova
approved these changes
Oct 16, 2025
rainersigwald
approved these changes
Oct 17, 2025
This was referenced Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging tag v17.12.50 into vs17.12 branch