[vs17.11] Merge v17.11.48 into vs17.11#12648
Merged
JanProvaznik merged 2 commits intodotnet:vs17.11from Oct 20, 2025
Merged
Conversation
…bdirectory on every build Recreate temp on linux using CreateTempSubdirectory on every build ---- #### AI description (iteration 1) #### PR Classification Security bug fix addressing the temporary folder creation issue on Linux. #### PR Summary This pull request secures the temporary directory creation in `src/Shared/TempFileUtilities.cs` by replacing the manual folder creation and permission checks with a call to `Directory.CreateTempSubdirectory` on Linux, thereby mitigating the risk of unauthorized temp folder creation. It directly addresses the linked [Security] work item by eliminating the potential for malicious actor intervention. - `src/Shared/TempFileUtilities.cs`: Uses `Directory.CreateTempSubdirectory` to create a unique, secure temp folder on Linux. - `src/Shared/TempFileUtilities.cs`: Removes outdated manual permission and folder collision handling logic. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> ---- #### AI description (iteration 2) #### PR Classification Security bug fix that addresses a vulnerability in temporary folder creation on Linux. #### PR Summary This pull request enhances security by reworking the Linux temporary folder creation in MSBuild to generate a fresh subdirectory on every build using `Directory.CreateTempSubdirectory`. - `src/Shared/TempFileUtilities.cs`: Replaced the custom folder creation and permission logic with a secure, native subdirectory creation method and removed the obsolete `userRWX` constant. - `eng/Versions.props`: Bumped the version prefix from 17.11.47 to 17.11.48. Related work items: #2541147
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR merges tag v17.11.48 into the vs17.11 branch, primarily updating the version number and simplifying the temporary folder creation logic for Linux by leveraging the Directory.CreateTempSubdirectory API.
Key Changes:
- Version bumped from 17.11.47 to 17.11.48
- Simplified Linux temp folder creation using
Directory.CreateTempSubdirectoryinstead of custom native calls - Removed complex permission handling and fallback logic for directory creation conflicts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/Versions.props | Version incremented to 17.11.48 |
| src/Shared/TempFileUtilities.cs | Refactored temp directory creation to use .NET API instead of native calls on Linux |
rainersigwald
approved these changes
Oct 17, 2025
YuliiaKovalova
approved these changes
Oct 20, 2025
This was referenced Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging tag v17.11.48 into vs17.11 branch