Prevent race condition in LoggingService

[YuliiaKovalova]

Fixes: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2320135/

Context

Reset() method invocation sometimes causes exception System.IO.IOException: 'The handle is invalid.'.
Very likely it happens on application shutdown.
The assumption is:

• ShutdownComponent starts and gets the _lockObject
• It cleans up/disposes the events
• Meanwhile our logging thread is trying to use those same events without checking _lockObject in context of StartLoggingEventProcessing()

Changes Made

1. All local vars to prevent a race to set fields null and then use them
2. Add catch if fields got disposed while Logging still was going on.

Testing

N/A

[rainersigwald]

I don't think I understand how this helps. Isn't there still a race between thread 1 seeing that it's non-null and calling into it and thread 2 calling Dispose()?

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

[JanKrivanek]

Let's discuss this one

[JanProvaznik]

It improves the situation, but please update the description. I wouldn't say it's a double check pattern, it 1. prevents a race to set a field null and then use it and 2. catches a dispose race.

[JanKrivanek]

LGTM!

[YuliiaKovalova]

The solution isn't ideal, but it allows to avoid "System.IO.IOException: 'The handle is invalid.'" exception.
if it's not enough and causes other crashes, we will reconsider it.