Merged
Conversation
b6f9f79 to
0b6af78
Compare
MichalPavlik
approved these changes
Jan 10, 2025
surayya-MS
approved these changes
Jan 10, 2025
Member
Author
|
I've worked with @surayya-MS and @JanProvaznik to check if this is enough to remove the assembly conflict. It appears that this should be sufficient. The current main branch silently fails in windows powershell and works with this change when using the test script I've also started exp insertion recommended by @YuliiaKovalova, unless this PR is urgent-urgent I would prefer to wait with the merge until it finishes. |
YuliiaKovalova
approved these changes
Jan 13, 2025
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/azure-pipelines-tasks#20734
Context
This is a hopefully temporary rollback due to the assembly collision in Microsoft.IO.Redist
Changes Made
Removed the conflicting dependency.
Testing
Existing tests.
Notes
We have a proper fix here: microsoft/azure-pipelines-tasks-common-packages#422
However since this change is breaking a lot of people, we're doing this as an interim-patch.