[BuildCheck] Limit number of emitted messages per rule. #10625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AR-May
force-pushed
the
bc-add-limiting-messages
branch
from
42c30e6 to
467856d
Compare
AR-May
force-pushed
the
bc-add-limiting-messages
branch
from
467856d to
ddc6e86
Compare
Member
|
Let's simplify this - as diuscused, the limit should be very easily addable to |
AR-May
force-pushed
the
bc-add-limiting-messages
branch
from
ddc6e86 to
94e1db5
Compare
JanKrivanek
reviewed
Sep 11, 2024
JanKrivanek
reviewed
Sep 12, 2024
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
This looks great!
Thanks!
The only thing holding me off the signoff is calling the dismounting
src/Build/BuildCheck/Infrastructure/BuildCheckManagerProvider.cs
Outdated
Show resolved
Hide resolved
JanKrivanek
approved these changes
Sep 13, 2024
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
This looks great!
I have couple small comments.
The one thing that I'd realy want to see changed before merging - is the dismounting of the check right after the last report that fits into the count.
src/Build/BuildCheck/Infrastructure/BuildCheckCentralContext.cs
Outdated
Show resolved
Hide resolved
maridematte
approved these changes
Sep 13, 2024
Member
maridematte
left a comment
maridematte
left a comment
There was a problem hiding this comment.
Could you also add a comment somewhere linking to the issue? Just so in the future we don't forget and have a reference when removing the temp code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fixes #10414
Context
If BuildCheck emits a lot of messages, it is possible that the build will hang. Since the real reason of the hang is yet unclear, we have decided to limit number of messages emitted by build-in checks.
Changes Made
CheckWrapperso that we can limit number of messages per check.Testing
unit tests + manual testing