-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Labels
Description
(adapted from #9255)
This time the vs17.9 msbuild branch would be created much earlier to give us opportunity to take feature PRs.
Preparation for the release:
- Create
vs17.9branch - Modify the VS insertion so that it flows from MSBuild vs17.9 to VS main here.
- Disable automated run of https://dev.azure.com/devdiv/DevDiv/_release?definitionId=2153&view=mine&_a=releases
- Add MSBuild main to the experimental VS insertion flow.
- Create darc channel for
VS 17.10if it doesn't already exist
darc add-channel --name "VS 17.10" - Ping internal "First Responders" Teams channel to get the new channel made available as a promotion target (e.g. Make "VS 17.6" darc channel promotionable arcade#12150): Make VS 17.7 and 17.8 promotable arcade#12989
- Remove the
mainto old release channel default channel
darc delete-default-channel --repo https://github.com/dotnet/msbuild --branch main --channel "VS 17.9" - Associate the
mainbranch with the next release channel
darc add-default-channel --channel "VS 17.10" --branch main --repo https://github.com/dotnet/msbuild - Check subscriptions for the current channel
VS 17.9and update as necessary (for instance, SDK'smainbranch should usually be updated, whereas release branches often should not be
darc get-subscriptions --exact --source-repo https://github.com/dotnet/msbuild --channel "VS 17.9"\ - Update channel
VS 17.9toVS 17.10for the sdk main subscription
`darc update-subscription --id sdk_main_branch_id - Ensure that the current release channel
VS 17.9is associated with the correct release branch
darc get-default-channels --source-repo https://github.com/dotnet/msbuild --branch vs17.9
if it is not,darc add-default-channel --channel "VS 17.9" --branch vs17.9 --repo https://github.com/dotnet/msbuild - Fast-forward merge the correct commit (the one that is currently inserted to VS main) to the
vs17.9branch
git push upstream 797fd829a374a880f63fd4eea4ea6990404c48f4:refs/heads/vs17.9Note the commit for future steps
The branch should point to a good, recent spot, so the final-branding PR goes in on top of the right set of commits. - Update the branch merge flow in
dotnet/versionsto have the currently-in-servicing branches (extend Automate MSBuild's merge chain versions#867): MSBuild 17.7 -> 17.8 versions#911 - Fix OptProf data flow for the new vs17.9 branch
- Run manually OptProf pipeline for vs17.9 ('Run pipeline' in upper right)
- Run the MSBuild pipeline for vs17.9 without OptProf (set
SkipApplyOptimizationDatavariable in 'Advanced options' section of the 'Run pipeline' menu totrue) - Run the MSBuild pipeline for vs17.9 with no extra vustomization - OptProf should succeed now
- Create 17.10 branding PR
- Create 17.9 localization ticket: https://aka.ms/ceChangeLocConfig (requesting to add localization for 17.9)
https://ceapex.visualstudio.com/CEINTL/_workitems/edit/907751. https://ceapex.visualstudio.com/CEINTL/_workitems/edit/931651 - Enable 17.9 localization - by setting
EnableReleaseOneLocBuildtotrue - Disable 17.8 localization - by setting
EnableReleaseOneLocBuildtofalse - Merge 17.10 branding PR
- Create and merge PR including public API baseline package version change (see Public api analyzer change #8116 (comment)): Version 17.8 #8949
- When VS main snaps to 17.9 and updates its version to 17.10, modify the VS insertion so that it flows from MSBuild main to VS main.
- Create 17.8 localization ticket: https://aka.ms/ceChangeLocConfig (requesting to remove localization for 17.8)
https://ceapex.visualstudio.com/CEINTL/_workitems/edit/936778 - (???) Remove MSBuild main from the experimental VS insertion flow.
- Update the release-branch insertion release definition to have
InsertTargetBranchrel/d17.9. - Turn the release pipeline back on.
- Prepare final branding PR for
vs17.9but⚠️ DO NOT MERGE IT YET⚠️ : -
Prepare QB-mode bug for final branding insertion in internal VS repo - Merge final branding to
vs17.9branch - Update perfstar MSBuild insertions configuration: example PR
- Note down the build (will be helpful for requesting nuget packages publishing): (https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8436672&view=results)
-
Get QB approval - Merge to VS (babysit the automatically generated VS insertion PR https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequests for the MSBuild commit noted in above step): https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/518456
-
Update the PackageValidationBaselineVersion to the latest released version (17.9.0) - this might require temporary addition of build artifacts feed as the new version is not yet added to the official feeds (this is post release). This can trigger a high severity CG error (https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/secure-supply-chain/how-to-securely-configure-package-source-files) - however it should be fine to keep this temporary feed untill the release. - Disable the 17.8 localization - by setting
EnableReleaseOneLocBuildtofalse
ASAP On/After GA (based on release schedule (internal) https://dev.azure.com/devdiv/DevDiv/_wiki/wikis/DevDiv.wiki/10097/Dev17-Release):
- Push packages to nuget.org (not currently automated, contact dnceng - search "Publish MSBuild 17.6 to NuGet.org" email subject for template).
- Publish docs: submit reference request at https://aka.ms/publishondocs
- Click on the link labeled Request – Reference Publishing
- You can use existing ticket as a reference
-
Remove the temporarily added build feed fromnuget.configif it was added in theUpdate the PackageValidationBaselineVersionstep - Update
mainsubscriptions to the new channel (this can be done before or after release - depending on when the source repos from our previous - VS 17.9 - channle start to publish in the next - VS 17.10 - channel)
darc get-subscriptions --exact --target-repo https://github.com/dotnet/msbuild --target-branch main - Create the 17.9 release
- Create tag (can be done upfront)
git checkout <commit noted above> git tag v17.9.3 git push upstream v17.9.3- Create Release in Github with
Create Release from TagGH option (https://github.com/dotnet/msbuild/releases/new?tag=v17.9.3) - the release notes can be prepopulated (Generate Release Notes)