Skip to content

WriteOnlyWhenDifferent should check with the same encoding #8361

New issue
New issue
Open
Open
WriteOnlyWhenDifferent should check with the same encoding#8361

Description

@stan-sz

stan-sz
openedon Jan 27, 2023

The encoding is missing on the check for WriteOnlyWhenDifferent

msbuild/src/Tasks/FileIO/WriteLinesToFile.cs

Line 102 in 56087a9

string existingContents = System.IO.File.ReadAllText(File.ItemSpec);

while it's present on the subsequent write:

msbuild/src/Tasks/FileIO/WriteLinesToFile.cs

Line 121 in 56087a9

System.IO.File.WriteAllText(File.ItemSpec, contentsAsString, encoding);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Area: TasksIssues impacting the tasks shipped in Microsoft.Build.Tasks.Core.dll.Partner requestbackloghelp wantedIssues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim.triaged

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions