Workaround the sanity check breaking. Revert this commit when changewave

17_0 is deleted.
dotnet · Oct 13, 2021 · ea01e3c · ea01e3c
1 parent 5e1ae3f
commit ea01e3c
Show file tree

Hide file tree

Showing 6 changed files with 74 additions and 8 deletions.
diff --git a/src/Build.OM.UnitTests/Microsoft.Build.Engine.OM.UnitTests.csproj b/src/Build.OM.UnitTests/Microsoft.Build.Engine.OM.UnitTests.csproj
@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <Import Project="..\Shared\FileSystemSources.proj" />
+  <Import Project="..\Shared\FileSystemSourcesBase.proj" />
   <Import Project="..\Shared\DebuggingSources.proj" />
 
   <PropertyGroup>

diff --git a/src/Build.OM.UnitTests/MockManagedFileSystemChangeWavesExtension.cs b/src/Build.OM.UnitTests/MockManagedFileSystemChangeWavesExtension.cs
@@ -0,0 +1,28 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+// This file is a workaround from PR https://github.com/dotnet/msbuild/pull/6771.
+// We need to avoid using ChangeWaves.cs in Microsoft.Build.Engine.OM.UnitTests.
+// It mocks ManagedFileSystemChangeWavesExtension.cs.
+// We are mocking the call ChangeWaves.AreFeaturesEnabled(ChangeWaves.Wave17_0) as true.
+// After deleting changewave 17_0 delete this file as well.
+
+#if FEATURE_MSIOREDIST
+namespace Microsoft.Build.Shared.FileSystem
+{
+    /// <summary>
+    /// Implementation of file system operations directly over the dot net managed layer
+    /// </summary>
+
+    internal partial class ManagedFileSystem : IFileSystem
+    {
+        private static bool ShouldUseMicrosoftIO
+        {
+            get
+            {
+                return true;
+            }
+        }
+    }
+}
+#endif
diff --git a/src/Shared/FileSystem/ManagedFileSystem.cs b/src/Shared/FileSystem/ManagedFileSystem.cs
@@ -11,7 +11,7 @@ namespace Microsoft.Build.Shared.FileSystem
     /// <summary>
     /// Implementation of file system operations directly over the dot net managed layer
     /// </summary>
-    internal class ManagedFileSystem : IFileSystem
+    internal partial class ManagedFileSystem : IFileSystem
     {
         private static readonly ManagedFileSystem Instance = new ManagedFileSystem();
 
@@ -69,7 +69,7 @@ Microsoft.IO.SearchOption searchOption
         public virtual IEnumerable<string> EnumerateFiles(string path, string searchPattern, SearchOption searchOption)
         {
 #if FEATURE_MSIOREDIST
-            return ChangeWaves.AreFeaturesEnabled(ChangeWaves.Wave17_0)
+            return ShouldUseMicrosoftIO
                 ? HandleFileLoadException(
                     (path, searchPattern, searchOption) => Microsoft.IO.Directory.EnumerateFiles(path, searchPattern, searchOption),
                     path,
@@ -85,7 +85,7 @@ public virtual IEnumerable<string> EnumerateFiles(string path, string searchPatt
         public virtual IEnumerable<string> EnumerateDirectories(string path, string searchPattern, SearchOption searchOption)
         {
 #if FEATURE_MSIOREDIST
-            return ChangeWaves.AreFeaturesEnabled(ChangeWaves.Wave17_0)
+            return ShouldUseMicrosoftIO
                 ? HandleFileLoadException(
                     (path, searchPattern, searchOption) => Microsoft.IO.Directory.EnumerateDirectories(path, searchPattern, searchOption),
                     path,
@@ -101,7 +101,7 @@ public virtual IEnumerable<string> EnumerateDirectories(string path, string sear
         public virtual IEnumerable<string> EnumerateFileSystemEntries(string path, string searchPattern, SearchOption searchOption)
         {
 #if FEATURE_MSIOREDIST
-            return ChangeWaves.AreFeaturesEnabled(ChangeWaves.Wave17_0)
+            return ShouldUseMicrosoftIO
                 ? HandleFileLoadException(
                     (path, searchPattern, searchOption) => Microsoft.IO.Directory.EnumerateFileSystemEntries(path, searchPattern, searchOption),
                     path,

diff --git a/src/Shared/FileSystemSources.proj b/src/Shared/FileSystemSources.proj
@@ -1,7 +1,9 @@
 <Project>
+    <Import Project="FileSystemSourcesBase.proj" />
+
     <ItemGroup>
-      <Compile Include="$(MSBuildThisFileDirectory)FileSystem\*.cs">
-        <Link>FileSystem\%(Filename).cs</Link>
+      <Compile Include="$(MSBuildThisFileDirectory)ManagedFileSystemChangeWavesExtension.cs">
+        <Link>FileSystem\ManagedFileSystemChangeWavesExtension.cs</Link>
       </Compile>
     </ItemGroup>
-</Project>
+</Project>
diff --git a/src/Shared/FileSystemSourcesBase.proj b/src/Shared/FileSystemSourcesBase.proj
@@ -0,0 +1,7 @@
+<Project>
+    <ItemGroup>
+      <Compile Include="$(MSBuildThisFileDirectory)FileSystem\*.cs">
+        <Link>FileSystem\%(Filename).cs</Link>
+      </Compile>
+    </ItemGroup>
+</Project>
diff --git a/src/Shared/ManagedFileSystemChangeWavesExtension.cs b/src/Shared/ManagedFileSystemChangeWavesExtension.cs
@@ -0,0 +1,29 @@
+// Copyright (c) Microsoft. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+// This file is a workaround from PR https://github.com/dotnet/msbuild/pull/6771.
+// We need to avoid using ChangeWaves.cs in Microsoft.Build.Engine.OM.UnitTests.
+// Usage of ChangeWaves class in ManagedFileSystem is done in this separate file.
+// In Microsoft.Build.Engine.OM.UnitTests this part is mocked (see MockManagedFileSystemChangeWavesExtension.cs).
+// After deleting changewave 17_0 delete this file as well.
+
+#if FEATURE_MSIOREDIST
+using Microsoft.Build.Utilities;
+
+namespace Microsoft.Build.Shared.FileSystem
+{
+    /// <summary>
+    /// Implementation of file system operations directly over the dot net managed layer
+    /// </summary>
+    internal partial class ManagedFileSystem : IFileSystem
+    {
+        private static bool ShouldUseMicrosoftIO
+        {
+            get
+            {
+                return ChangeWaves.AreFeaturesEnabled(ChangeWaves.Wave17_0);
+            }
+        }
+    }
+}
+#endif