[android] Update to latest AndroidX packages with better Trimmable support. #5889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redth
approved these changes
Apr 7, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@eerhardt This should fix most (?) of the MAUI Android size regression. If you are seeing any other untrimmed assemblies, please let me know! |
Eilon
added
the
area-infrastructure
|
Does AndroidX pushes to maestro? couldn't we do this bumps via maestro? |
|
I don't know what maestro is, so I guess not. 😁 |
|
Context:
GPS-FB-MLKit dependencies were updated with trimmable support PR: xamarin/GooglePlayServicesComponents#597 |
jonathanpeppers
approved these changes
Apr 12, 2022
|
AndroidX is always coming from NuGet.org, so the release pipeline that pushes those would need to send those builds to Maestro. @rmarinho is dependabot setup for dotnet/maui? That might actually be simpler for this case. |
|
Can we merge this? It fixes a ~1.5MB app size regression. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android-libraries#519
Context: dotnet/android-libraries#520
The AndroidX packages that MAUI currently uses all support trimming, however some of their new dependencies did not, such as
Xamarin.Kotlin.StdLib. This caused a size regression on Android because these new libraries were not being trimmed.AndroidX dependencies have been updated with trimming support, and new packages have been released that update the dependency tree.
This PR updates MAUI to use these new AndroidX versions.