Ported pending fixes from Xamarin.Forms #5510

jsuarezruiz · 2022-03-23T10:04:34Z

Description of Change

Ported pending fixes from Xamarin.Forms:

[UWP] Fix ListView grouping issue xamarin/Xamarin.Forms#14653
[Android] Fix crash animate two times the Frame scale xamarin/Xamarin.Forms#14606
[Core] Fix NRE in ListView Command validation xamarin/Xamarin.Forms#14580
[Bug] [UWP] Fix FontIcons alignment xamarin/Xamarin.Forms#15047
[Android] Fix content pages not Garbage collected xamarin/Xamarin.Forms#14717
[Android] Avoid reset ListView adapter in TabbedPage if is already disposed xamarin/Xamarin.Forms#14635
Prevent CollectionView.EmptyView from showing up while it shouldn't on iOS xamarin/Xamarin.Forms#15122
[iOS] Fix CollectionView crash in iOS 9 xamarin/Xamarin.Forms#14925
[Android] Fix CollectionView item renderer disposal on Android (Memory Leak) xamarin/Xamarin.Forms#14882
ListView: avoid that disabling RefreshAllowed cancels refresh indicator on Android, fixes #8384 xamarin/Xamarin.Forms#14816
[iOS] Fix issue with gifs and differents DefaultThreadCurrentCulture xamarin/Xamarin.Forms#14698
[iOS] Fix issue with ListView wrong top padding in iOS 15 xamarin/Xamarin.Forms#14671
[iOS] CollectionView not applying "Selected" VisualState to pre-selected items xamarin/Xamarin.Forms#14672
[iOS] Fix: CollectionView was not updating when it was invisible xamarin/Xamarin.Forms#14384
fix memory leak (and some crashes) in ItemsViewController (iOS) xamarin/Xamarin.Forms#14111

Are the pending fixes from the latest Xamarin.Forms Service Releases.

jsuarezruiz · 2022-03-23T10:08:48Z

src/Compatibility/Core/src/Windows/CellControl.cs


-				// reuse cell
+				// Reuse cell


Fix ListView grouping not working on Windows
xamarin/Xamarin.Forms#14653

jsuarezruiz · 2022-03-23T10:09:52Z

src/Core/src/Platform/Android/TransformationExtensions.cs

-			platformView.ScaleX = (float)(view.Scale * view.ScaleX);
+			var scale = view.Scale;
+
+			if (double.IsNaN(scale))


Fix crash animating several times in a rowtimes Frame scale
xamarin/Xamarin.Forms#14606

jsuarezruiz · 2022-03-23T10:10:38Z

src/Controls/src/Core/ListView.cs

@@ -606,7 +606,7 @@ internal override void OnIsPlatformEnabledChanged()

 		void OnCommandCanExecuteChanged(object sender, EventArgs eventArgs)
 		{
-			RefreshAllowed = RefreshCommand.CanExecute(null);
+			RefreshAllowed = RefreshCommand != null && RefreshCommand.CanExecute(null);


Fix NRE in ListView Command
xamarin/Xamarin.Forms#14580

jsuarezruiz · 2022-03-23T10:12:50Z

src/Compatibility/Core/src/Windows/FontImageSourceHandler.cs

-					var x = (float)layout.DrawBounds.X * -1;
-
-					ds.DrawTextLayout(layout, x, 1f, iconcolor);
+					ds.DrawTextLayout(layout, 1f, 1f, iconcolor);


Fix FontIcons alignment
xamarin/Xamarin.Forms#15047

jsuarezruiz · 2022-03-23T10:14:02Z

src/Controls/src/Core/Compatibility/Handlers/Shell/Android/ShellToolbarTracker.cs

@@ -185,7 +185,10 @@ protected override void Dispose(bool disposing)
 				_currentMenuItems?.Clear();
 				_currentToolbarItems?.Clear();

+				_drawerLayout.RemoveDrawerListener(_drawerToggle);


Fix content pages not Garbage collected
xamarin/Xamarin.Forms#14717

jsuarezruiz · 2022-03-23T10:14:42Z

src/Compatibility/Core/src/Android/Renderers/ListViewAdapter.cs

@@ -612,6 +612,10 @@ void OnDataChanged()
 				// we need to reset the ListView's adapter to reflect the changes on page B
 				// If there header and footer are present at the reset time of the adapter
 				// they will be DOUBLE added to the ViewGround (the ListView) causing indexes to be off by one. 
+
+				if (_realListView.IsDisposed())


Avoid reset ListView adapter in TabbedPage if is already disposed
xamarin/Xamarin.Forms#14635

jsuarezruiz · 2022-03-23T10:15:16Z

src/Compatibility/Core/src/iOS/CollectionView/ItemsViewController.cs

@@ -19,7 +19,7 @@ public abstract class ItemsViewController<TItemsView> : UICollectionViewControll
 		public TItemsView ItemsView { get; }
 		protected ItemsViewLayout ItemsViewLayout { get; set; }
 		bool _initialized;
-		bool _isEmpty;
+		bool _isEmpty = true;


Prevent CollectionView.EmptyView from showing up while it shouldn't on iOS
xamarin/Xamarin.Forms#15122

jsuarezruiz · 2022-03-23T10:16:19Z

src/Compatibility/Core/src/iOS/CollectionView/ItemsViewController.cs

+			bool isRtl;
+
+			if (PlatformVersion.IsAtLeast(10))
+				isRtl = CollectionView.EffectiveUserInterfaceLayoutDirection == UIUserInterfaceLayoutDirection.RightToLeft;


Fix CollectionView crash in iOS < 10
xamarin/Xamarin.Forms#14925

jsuarezruiz · 2022-03-23T10:17:01Z

src/Controls/src/Core/Handlers/Items/Android/ItemContentView.cs

@@ -46,6 +46,7 @@ internal void Recycle()
 				RemoveView(platformView);
 			}

+			Content?.Dispose();


Fix CollectionView item renderer disposal on Android (Memory Leak)
xamarin/Xamarin.Forms#14882

jsuarezruiz · 2022-03-23T10:17:45Z

src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ListViewRenderer.cs

+				var isEnabled = Element.IsPullToRefreshEnabled && (Element as IListViewController).RefreshAllowed;
+				_refresh.Post(() =>
+				{
+					// NOTE: only disable while NOT refreshing, otherwise Command bindings CanExecute behavior will effectively


Avoid that disabling ListView RefreshAllowed cancels refresh indicator on Android
xamarin/Xamarin.Forms#14816

jsuarezruiz · 2022-03-23T10:19:22Z

src/Compatibility/Core/src/iOS/Renderers/ImageAnimationHelper.cs

@@ -52,9 +53,9 @@ public void AddFrameData(int index, CGImageSource imageSource)
 				using (var delayTimeValue = gifImageProperties?.ValueForKey(ImageIO.CGImageProperties.GIFDelayTime))
 				{
 					if (unclampedDelayTimeValue != null)
-						double.TryParse(unclampedDelayTimeValue.ToString(), out delayTime);
+						double.TryParse(unclampedDelayTimeValue.ToString(), NumberStyles.Any, CultureInfo.InvariantCulture, out delayTime);


Fix issue with gifs and differents DefaultThreadCurrentCulture on iOS
xamarin/Xamarin.Forms#14698

jsuarezruiz · 2022-03-23T10:19:59Z

src/Compatibility/Core/src/iOS/Renderers/ListViewRenderer.cs

@@ -274,6 +274,9 @@ protected override void OnElementChanged(ElementChangedEventArgs<ListView> e)
 					}
 					_tableViewController = new FormsUITableViewController(e.NewElement, _usingLargeTitles);
 					SetNativeControl(_tableViewController.TableView);
+
+					if (Forms.IsiOS15OrNewer)
+						_tableViewController.TableView.SectionHeaderTopPadding = new nfloat(0);


Fix issue with ListView wrong top padding in iOS 15
xamarin/Xamarin.Forms#14671

jsuarezruiz · 2022-03-23T10:20:28Z

src/Controls/src/Core/Handlers/Items/iOS/TemplatedCell.cs

@@ -172,6 +172,8 @@ void SetRenderer(IPlatformViewHandler renderer)

 			InitializeContentConstraints(platformView);

+			UpdateVisualStates();


Fix CollectionView not applying "Selected" VisualState to pre-selected items on iOS
https://github.com/xamarin/Xamarin.Forms/pull/14672/files

rmarinho · 2022-03-24T15:34:00Z

Don-t we need to port the fixes to the handlers also? For example ItemsViewController

PureWeen · 2022-03-24T17:22:50Z

src/Controls/src/Core/Compatibility/Handlers/ListView/Windows/CellControl.cs

-					wasGroupHeader = oldCell.GetIsGroupHeader<ItemsView<Cell>, Cell>();
-				}
-
+				Cell oldCell = Cell;


xamarin/Xamarin.Forms#14653

jsuarezruiz · 2022-03-25T09:20:59Z

Don-t we need to port the fixes to the handlers also? For example ItemsViewController

Sure thing, there are also changes in src/Controls/src/Core/Handlers/Items/iOS/ItemsViewController.cs

PureWeen · 2022-03-25T17:45:30Z

/azp run

azure-pipelines · 2022-03-25T17:45:50Z

Azure Pipelines successfully started running 2 pipeline(s).

Ported pending fixes from Xamarin.Forms

050fd7b

jsuarezruiz added the t/housekeeping ♻︎ label Mar 23, 2022

jsuarezruiz commented Mar 23, 2022

View reviewed changes

Fix build errors

ac6a07c

Redth requested a review from PureWeen March 24, 2022 17:10

Redth changed the title ~~[Housekeeping] Ported pending fixes from Xamarin.Forms~~ Ported pending fixes from Xamarin.Forms Mar 24, 2022

Redth requested a review from rmarinho March 24, 2022 17:22

PureWeen reviewed Mar 24, 2022

View reviewed changes

Merge branch 'main' into pending-fixes-xamarinforms

87adbfb

PureWeen added 2 commits March 25, 2022 14:05

Merge branch 'main' into pending-fixes-xamarinforms

477cbe3

- fix static get of accent color

1ba1974

PureWeen approved these changes Mar 25, 2022

View reviewed changes

PureWeen added this to the 6.0.300-rc.1 milestone Mar 25, 2022

PureWeen merged commit 41bb8c9 into main Mar 26, 2022

PureWeen deleted the pending-fixes-xamarinforms branch March 26, 2022 01:37

jsuarezruiz mentioned this pull request Mar 30, 2022

ListView WinUI Group Header renderers incorrect string for first group header #4166

Closed

github-actions bot locked and limited conversation to collaborators Dec 21, 2023

samhouts added the fixed-in-6.0.300-rc.1 Look for this fix in 6.0.300-rc.1! label Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ported pending fixes from Xamarin.Forms #5510

Ported pending fixes from Xamarin.Forms #5510

jsuarezruiz commented Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

jsuarezruiz Mar 23, 2022

rmarinho commented Mar 24, 2022

PureWeen Mar 24, 2022

jsuarezruiz commented Mar 25, 2022

PureWeen commented Mar 25, 2022

azure-pipelines bot commented Mar 25, 2022

		@@ -172,6 +172,8 @@ void SetRenderer(IPlatformViewHandler renderer)

		InitializeContentConstraints(platformView);

		UpdateVisualStates();

Ported pending fixes from Xamarin.Forms #5510

Ported pending fixes from Xamarin.Forms #5510

Conversation

jsuarezruiz commented Mar 23, 2022

Description of Change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmarinho commented Mar 24, 2022

Choose a reason for hiding this comment

jsuarezruiz commented Mar 25, 2022

PureWeen commented Mar 25, 2022

azure-pipelines bot commented Mar 25, 2022