Skip to content

Comments

Switch to dispatcher so Dispose is called after DestroyView#5064

Merged
PureWeen merged 1 commit intorelease/6.0.2xx-preview14from
fix_shell_android_navigation
Mar 4, 2022
Merged

Switch to dispatcher so Dispose is called after DestroyView#5064
PureWeen merged 1 commit intorelease/6.0.2xx-preview14from
fix_shell_android_navigation

Conversation

@PureWeen
Copy link
Member

@PureWeen PureWeen commented Mar 4, 2022

Description of Change

Activity.RunOnUIThread will execute the delegate immediately if you are on the UIThread. So, we need to change the dispose call back to just using the dispatcher so that it's always queue'd and called after DestroyView is called

Issues Fixed

Fixes #5062

@PureWeen PureWeen requested a review from Redth March 4, 2022 19:37
@PureWeen PureWeen enabled auto-merge (squash) March 4, 2022 19:41
@PureWeen PureWeen merged commit 0e86703 into release/6.0.2xx-preview14 Mar 4, 2022
@PureWeen PureWeen deleted the fix_shell_android_navigation branch March 4, 2022 20:16
@samhouts samhouts added area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/android labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@samhouts samhouts added the fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-6.0.200-preview.14.2 Look for this fix in 6.0.200-preview.14.2! platform/android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants